Skip to content

Remove all the private participants from a participatory space#8866

Merged
ahukkanen merged 38 commits intodecidim:developfrom
eliegaboriau:feature/delete_all_participants_when_adding
Apr 29, 2022
Merged

Remove all the private participants from a participatory space#8866
ahukkanen merged 38 commits intodecidim:developfrom
eliegaboriau:feature/delete_all_participants_when_adding

Conversation

@eliegaboriau
Copy link
Copy Markdown
Contributor

@eliegaboriau eliegaboriau commented Feb 21, 2022 •
edited
Loading

🎩 What? Why?

PR to add the possibility of deleting all existing private participants of a participatory space when importing others via csv
Add a button to delete all current private participants
Add a confirm dialog box

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

  • Go to the private user page of a participatory space
  • Click on import via csv
  • Notice that you don't have any user
    image
  • Fill the file field
  • Click on "Upload"
  • Click on import via csv
  • Notice that you can delete users
    image
  • Click on delete all
  • Notice that is asks for confirmation
    image
  • Confirm
  • Notice that all your current users have been deleted

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

♥️ Thank you!

@eliegaboriau eliegaboriau mentioned this pull request Feb 21, 2022
Closed
@eliegaboriau eliegaboriau marked this pull request as ready for review February 21, 2022 14:35
armandfardeau
armandfardeau reviewed Feb 21, 2022
View reviewed changes
Comment thread CHANGELOG.md Outdated
@eliegaboriau eliegaboriau marked this pull request as draft February 22, 2022 17:01
@eliegaboriau eliegaboriau marked this pull request as ready for review February 23, 2022 10:12
@andreslucena andreslucena linked an issue Mar 2, 2022 that may be closed by this pull request
Remove all the current participants from Private Participants #6018
Closed
2 tasks
andreslucena
andreslucena requested changes Mar 3, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are minimal things to change. I think this is a great contribution, specially for private organizations!

Comment thread CHANGELOG.md Outdated
Comment thread decidim-admin/app/controllers/decidim/admin/concerns/has_private_users_csv_import.rb Outdated
Comment thread ...dim-admin/app/views/decidim/admin/participatory_space_private_users_csv_imports/new.html.erb Outdated
Comment thread ...dim-admin/app/views/decidim/admin/participatory_space_private_users_csv_imports/new.html.erb Outdated
Comment thread ...dim-admin/app/views/decidim/admin/participatory_space_private_users_csv_imports/new.html.erb Outdated
Comment thread decidim-admin/spec/commands/decidim/admin/create_participatory_space_private_user_spec.rb Outdated
Comment thread decidim-admin/app/controllers/decidim/admin/concerns/has_private_users_csv_import.rb Outdated
Comment thread decidim-admin/spec/commands/decidim/admin/create_participatory_space_private_user_spec.rb Outdated
Comment thread decidim-admin/spec/commands/decidim/admin/create_participatory_space_private_user_spec.rb Outdated
Comment thread decidim-admin/spec/system/participatory_space_private_user_import_via_csv_spec.rb Outdated
@andreslucena andreslucena changed the title Remove all the current participants from private participants Remove all the private participants from a participatory space Mar 3, 2022
eliegaboriau and others added 2 commits March 7, 2022 14:57
@eliegaboriau @andreslucena
Update CHANGELOG.md
68ea218 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau @andreslucena
Update decidim-admin/app/views/decidim/admin/participatory_space_priv…
581acdc 
…ate_users_csv_imports/new.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
eliegaboriau and others added 10 commits March 7, 2022 15:02
@eliegaboriau @andreslucena
Update decidim-admin/app/views/decidim/admin/participatory_space_priv…
92bafea 
…ate_users_csv_imports/new.html.erb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau @andreslucena
Update decidim-admin/config/locales/en.yml
e00baef 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau @andreslucena
Update decidim-admin/config/locales/en.yml
d940ed5 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau @andreslucena
Update decidim-admin/config/locales/en.yml
e18b889 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau @andreslucena
Update decidim-admin/config/locales/en.yml
41a9b8e 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau @andreslucena
Update decidim-admin/config/locales/en.yml
978bc90 
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau @andreslucena
Update decidim-admin/spec/system/participatory_space_private_user_imp…
1a13ca4 
…ort_via_csv_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau
add scope
3fa62e3 
add test
@eliegaboriau
Merge branch 'feature/delete_all_participants_when_adding' of https:/…
5bdb55e 
…/github.com/eliegaboriau/decidim into feature/delete_all_participants_when_adding
@eliegaboriau
fix spelling of "imports" everywhere
b017a60
andreslucena
andreslucena requested changes Mar 9, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple more changes, and we're good to go!

Comment thread ...sses/spec/controllers/admin/participatory_space_private_users_csv_imports_controller_spec.rb Outdated
Comment thread decidim-admin/app/controllers/decidim/admin/concerns/has_private_users_csv_import.rb
Comment thread decidim-admin/spec/system/participatory_space_private_user_import_via_csv_spec.rb Outdated
@eliegaboriau eliegaboriau marked this pull request as draft March 9, 2022 10:13
eliegaboriau and others added 5 commits March 9, 2022 11:19
@eliegaboriau @andreslucena
Update decidim-participatory_processes/spec/controllers/admin/partici…
6248b22 
…patory_space_private_users_csv_imports_controller_spec.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@eliegaboriau
Merge branch 'feature/delete_all_participants_when_adding' of https:/…
a8d5ad0 
…/github.com/eliegaboriau/decidim into feature/delete_all_participants_when_adding
@eliegaboriau
fix change requests
069dd0e
@eliegaboriau
fix tests
bb4ce1e
@eliegaboriau
Merge branch 'decidim:develop' into feature/delete_all_participants_w…
832ae1b 
…hen_adding
@eliegaboriau eliegaboriau marked this pull request as ready for review March 14, 2022 11:24
@andreslucena andreslucena self-requested a review March 14, 2022 12:30
andreslucena
andreslucena approved these changes Apr 4, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I've missed the last changes. LGTM

@ahukkanen ahukkanen merged commit 94e72e4 into decidim:develop Apr 29, 2022
This was referenced May 2, 2022
Merged
Merged
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

@ahukkanen ahukkanen ahukkanen approved these changes

@armandfardeau armandfardeau Awaiting requested review from armandfardeau

Assignees

No one assigned

Labels

module: core

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

Remove all the current participants from Private Participants

5 participants

@eliegaboriau @andreslucena @ahukkanen @armandfardeau @alecslupu