Add base URI to meta image URLs#9125
Merged
ahukkanen merged 3 commits intodecidim:developfrom Apr 4, 2022
Merged
Conversation
Member
|
There's an unrelated failing spec, already reported at #9017 |
entantoencuanto
added a commit
to PopulateTools/decidim
that referenced
this pull request
Apr 5, 2022
* chore/meetings_optimization: Add touch:true to Follow association with followable Fragment cache meetings partial in meetings index Bump minimist and node-forge (decidim#9131) Bump puma from 5.6.2 to 5.6.4 (decidim#9132) Add base URI to meta image URLs (decidim#9125) Make Decidim fully configurable via ENV vars part II (decidim#8990) Allow assembly admins to manage components in child assemblies (decidim#8955) Export calendar improvements (decidim#9035) Add reminders for publishing reports to meeting authors (decidim#8757) VAPID key generator availabe in core (decidim#9107) Dont add external link container inside editor (decidim#9095)
Contributor
|
Can we also backport this to 0.26 please? |
lahdeero
pushed a commit
to mainio/decidim
that referenced
this pull request
Apr 8, 2022
* Add base url to meta image urls * No need to have organization in every test * Use variable iinstead repeating
ahukkanen
pushed a commit
that referenced
this pull request
Apr 12, 2022
Contributor
|
Great! I wonder if the methods you added could be built on to implement this improvement. |
Merged
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When linking Decidim instance to social media image is usually broken (see screenshot below) because it doesn't include base url (e.g.
https://meta.decidim.org). Correct usage of social meta tags is described for example in Twitter docs.Testing
https://meta.decidim.org/rails/active_storage/blobs/123--foobar.png📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots