Skip to content

VAPID key generator availabe in core#9107

Merged
andreslucena merged 4 commits intodevelopfrom
fix/vapid-task
Mar 29, 2022
Merged

VAPID key generator availabe in core#9107
andreslucena merged 4 commits intodevelopfrom
fix/vapid-task

Conversation

@quinHD
Copy link
Copy Markdown
Contributor

@quinHD quinHD commented Mar 28, 2022 •
edited
Loading

🎩 What? Why?

It fixes the VAPID keys generator. Now it works without the dev dependency

📌 Related Issues

Testing

bundle install --without development test
bundle exec rails db:migrate
It works without error

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@quinHD quinHD self-assigned this Mar 28, 2022
@quinHD quinHD changed the title Fix/vapid task VAPID key generator availabe in core Mar 28, 2022
@andreslucena andreslucena added module: core type: fix PRs that implement a fix for a bug project: PWA Barcelona City Council contract module: dev labels Mar 29, 2022
andreslucena
andreslucena approved these changes Mar 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@andreslucena andreslucena merged commit e2f5b9c into develop Mar 29, 2022
@andreslucena andreslucena deleted the fix/vapid-task branch March 29, 2022 09:58
@andreslucena andreslucena linked an issue Mar 29, 2022 that may be closed by this pull request
Running any Decidim rake tasks in non-dev environment fails #8961
Closed
@andreslucena andreslucena mentioned this pull request Mar 29, 2022
Closed
entantoencuanto added a commit to PopulateTools/decidim that referenced this pull request Apr 5, 2022
@entantoencuanto
Merge branch 'chore/meetings_optimization' into pwa-staging
6d6adcf 
* chore/meetings_optimization:
  Add touch:true to Follow association with followable
  Fragment cache meetings partial in meetings index
  Bump minimist and node-forge (decidim#9131)
  Bump puma from 5.6.2 to 5.6.4 (decidim#9132)
  Add base URI to meta image URLs (decidim#9125)
  Make Decidim fully configurable via ENV vars part II (decidim#8990)
  Allow assembly admins to manage components in child assemblies (decidim#8955)
  Export calendar improvements (decidim#9035)
  Add reminders for publishing reports to meeting authors (decidim#8757)
  VAPID key generator availabe in core (decidim#9107)
  Dont add external link container inside editor (decidim#9095)
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andreslucena andreslucena andreslucena approved these changes

Assignees

@quinHD quinHD

Labels

module: core module: dev project: PWA Barcelona City Council contract type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

0.27.0

Development

Successfully merging this pull request may close these issues.

Running any Decidim rake tasks in non-dev environment fails

3 participants

@quinHD @andreslucena @alecslupu