Dont add external link container inside editor#9095
Merged
ahukkanen merged 4 commits intodecidim:developfrom Mar 29, 2022
Merged
Dont add external link container inside editor#9095ahukkanen merged 4 commits intodecidim:developfrom
ahukkanen merged 4 commits intodecidim:developfrom
Conversation
andreslucena
approved these changes
Mar 28, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've checked it locally, it fixed the original bug report. Thanks!
Contributor
|
@lahdeero Can you backport to 0.26 please? |
lahdeero
pushed a commit
to mainio/decidim
that referenced
this pull request
Mar 29, 2022
* Dont add external link inside editor * Add test * Fix typo * Dont test same thing twice
entantoencuanto
added a commit
to PopulateTools/decidim
that referenced
this pull request
Apr 5, 2022
* chore/meetings_optimization: Add touch:true to Follow association with followable Fragment cache meetings partial in meetings index Bump minimist and node-forge (decidim#9131) Bump puma from 5.6.2 to 5.6.4 (decidim#9132) Add base URI to meta image URLs (decidim#9125) Make Decidim fully configurable via ENV vars part II (decidim#8990) Allow assembly admins to manage components in child assemblies (decidim#8955) Export calendar improvements (decidim#9035) Add reminders for publishing reports to meeting authors (decidim#8757) VAPID key generator availabe in core (decidim#9107) Dont add external link container inside editor (decidim#9095)
19 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Currently external links are added to links inside editor also, this doesn't make much sense because author knows that the link they added is external. This also adds problem that we add extra content to a link each time it is opened with the editor. Here we prevent external link containers to be added inside the editor.
📌 Related Issues
#9055
Testing
See #9055
📋 Checklist
docs/.