Fix meetings form embed type visibility#8602
Conversation
e4a08d8 to
29f2527
Compare
29f2527 to
7d730c7
Compare
This includes the PR decidim/decidim#8602 recently rebased on develop
|
Hi, @decidim/product , you can review this on populate staging |
|
@entantoencuanto I think there's a problem with this form. I can reproduce it locally and in https://decidim.populate.tools (https://decidim.populate.tools/processes/subprova/f/256/meetings/new) The problem is that I see the "Iframe access level" when I go to the meetings' creation form, even when I didn't select any meeting type What I expect to happen is to only see it when the meeting is of type "online" or "both" |
|
Hi, @andreslucena, I've deployed again rebuilding assets. It seems that the assets were not being compiled properly and the javascript responsible of hiding the iframe access level select was not present. In https://decidim.populate.tools/processes/subprova/f/256/meetings/new the select is now hidden. Locally I don't have the same issue as you, could you rebuild the development_app again from this branch and check if assets are compiled correctly? The exception in the console seems to not be related with this PR, in develop branch I see the same error. |
Now its working
Ok, reported at #8640 |
|
@entantoencuanto I've reviewed it. It's looking good 😄 Just a small change: as I mentioned in #8570, participants can't create Polls (at least for now), so it doesn't make sense to have the option "Open in live event page (with optional polls)":
It's also in the Acceptance criteria:
Can you remove that option only for participants 🙏🏽? Thanks |
andreslucena
left a comment
There was a problem hiding this comment.
As I mentioned in my last comment, can we drop the "live event" option from the meetings participant form 🙏🏽 ?
|
Changes added, ready to check, @andreslucena cc/ @decidim/product |



🎩 What? Why?
Please describe your pull request.
📌 Related Issues
Link your PR to an issue
Testing
This PR:
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
