Fix avatar thumbnail in participants' profile#8577
Merged
andreslucena merged 3 commits intodevelopfrom Dec 10, 2021
Merged
Conversation
91fdda1 to
2c58e3e
Compare
50a4d8a to
19fb74e
Compare
entantoencuanto
added a commit
to PopulateTools/decidim
that referenced
this pull request
Dec 10, 2021
* fix/meetings_form_embed_type_visibility: Fix tests by adding missing doubled attributes Include value in validation conditional Allow participants to set iframe access level of meetings Fix embed type visibility in participants form Remove blank option in meetings embed type select Fix avatar thumbnail in participants' profile (decidim#8577) Fix HTML injection in comments and meeting's description (decidim#8511) Add search, filters and sorting to admin panel budget projects (decidim#8592) Add cache key separator to cache_hash (decidim#8559) Move social login buttons to the top of the login modal (decidim#8574) Fix the meeting copy functionality (decidim#8430) Temporarily ignore CSS validation issue in CI (decidim#8597) Fix security instructions (decidim#8587)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We have a problem with the participants avatars thumbnails where it was resized in the browser instead of showing the thumbnailed version (!!).
It's really visible here:
where a 25x20 is actually a 1280x1061 image
This PR fixes that.
📌 Related Issues
Testing
Inspect a participant avatar. Check that it's much smaller
📷 Screenshots