Move social login buttons to the top of the login modal#8574
Merged
andreslucena merged 1 commit intodevelopfrom Dec 10, 2021
Merged
Move social login buttons to the top of the login modal#8574andreslucena merged 1 commit intodevelopfrom
andreslucena merged 1 commit intodevelopfrom
Conversation
carolromero
previously approved these changes
Nov 30, 2021
Also, move .button--social--mini to buttons SCSS file It was in decidim-core/app/packs/stylesheets/decidim/extras/_social_icons_mini.scss and it didn't make much sense there.
535544a to
85c48de
Compare
entantoencuanto
added a commit
to PopulateTools/decidim
that referenced
this pull request
Dec 10, 2021
* fix/meetings_form_embed_type_visibility: Fix tests by adding missing doubled attributes Include value in validation conditional Allow participants to set iframe access level of meetings Fix embed type visibility in participants form Remove blank option in meetings embed type select Fix avatar thumbnail in participants' profile (decidim#8577) Fix HTML injection in comments and meeting's description (decidim#8511) Add search, filters and sorting to admin panel budget projects (decidim#8592) Add cache key separator to cache_hash (decidim#8559) Move social login buttons to the top of the login modal (decidim#8574) Fix the meeting copy functionality (decidim#8430) Temporarily ignore CSS validation issue in CI (decidim#8597) Fix security instructions (decidim#8587)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While seeing about #8465, I've seen that we actually have different behavior between the login page and the login modal regarding the OAuth providers.
In the login page, we have the full buttons (icon + text) and they're on the top of the page.
In the login modal, we have the icon button, and they're on the bottom.
This PR fixes that, having the same behavior between these two sections.
As this touches design, this needs to be reviewed by @carolromero
📌 Related Issues
Testing
📷 Screenshots
Bear in mind that this is like the worst case scenario with 5 providers. I know instances with maximum of 3 OAuth providers, so it shouldn't break in mobile.