Skip to content

Add cache key separator to cache_hash#8559

Merged
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:ale/cache-separators
Dec 10, 2021
Merged

Add cache key separator to cache_hash#8559
andreslucena merged 1 commit intodecidim:developfrom
i-need-another-coffee:ale/cache-separators

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

This PR does not add any product development, but aims to improve a bit the developer experience, and handling while using Redis backend.

Testing

N/A

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

image
image

♥️ Thank you!

@alecslupu alecslupu marked this pull request as ready for review November 30, 2021 16:50
@alecslupu alecslupu force-pushed the ale/cache-separators branch from e211bcc to 3cb6376 Compare December 4, 2021 06:37
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 As far as I see, those are the only cells where we define the cache_hash method

@andreslucena andreslucena changed the title Adding cache key separator Add cache key separator to cache_hash Dec 10, 2021
@andreslucena andreslucena merged commit bab485f into decidim:develop Dec 10, 2021
entantoencuanto added a commit to PopulateTools/decidim that referenced this pull request Dec 10, 2021
* fix/meetings_form_embed_type_visibility:
  Fix tests by adding missing doubled attributes
  Include value in validation conditional
  Allow participants to set iframe access level of meetings
  Fix embed type visibility in participants form
  Remove blank option in meetings embed type select
  Fix avatar thumbnail in participants' profile (decidim#8577)
  Fix HTML injection in comments and meeting's description (decidim#8511)
  Add search, filters and sorting to admin panel budget projects (decidim#8592)
  Add cache key separator to cache_hash (decidim#8559)
  Move social login buttons to the top of the login modal (decidim#8574)
  Fix the meeting copy functionality (decidim#8430)
  Temporarily ignore CSS validation issue in CI (decidim#8597)
  Fix security instructions (decidim#8587)
@alecslupu alecslupu added this to the 0.26.0 milestone Jul 14, 2023
@alecslupu alecslupu deleted the ale/cache-separators branch October 31, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants