Skip to content

Evote bug fixing#8220

Merged
leio10 merged 6 commits intodevelopfrom
fix/evote-bug-fixing
Jul 22, 2021
Merged

Evote bug fixing#8220
leio10 merged 6 commits intodevelopfrom
fix/evote-bug-fixing

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Jul 20, 2021

🎩 What? Why?

Fixes several bugs found during evote QA.
Specifically:

  1. 83b6bd9: Voting public area - Only show "recover access code" modal when at least one of the email and the phone number are in the census;
  2. 1f3c701: Voting public area - Add "remaining time to vote" on election show view (previously only present in the index view);
  3. eee518a: Polling Officer Zone - Disable the "Complete voting" button when a voter is not marked as 'voted' - also, makes the checkbox clickable on the label (https://app.clickup.com/t/nxdtem);
  4. f4cbcf0: Election creation: limit question max selection parameter to min 1 (https://app.clickup.com/t/nxdrx6);
  5. 10d64c5: Voting public area - Don't show "remaining time to vote" BEFORE the election voting time starts (https://app.clickup.com/t/nxejkt);
  6. 1d3dcd5: Monitoring Committee Zone - verifiable election file URL pointing to BB

📷 Screenshots

  1. remaining time

  2. disable_button.mov

@orlera orlera self-assigned this Jul 20, 2021
@orlera orlera mentioned this pull request Jul 20, 2021
@orlera orlera marked this pull request as ready for review July 22, 2021 14:34
@leio10 leio10 added module: elections type: fix PRs that implement a fix for a bug labels Jul 22, 2021
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! 👍

@leio10 leio10 merged commit b6a0047 into develop Jul 22, 2021
@leio10 leio10 deleted the fix/evote-bug-fixing branch July 22, 2021 15:10
entantoencuanto added a commit that referenced this pull request Jul 26, 2021
* develop: (32 commits)
  Remove obsolete rake webpack task (#8237)
  Active storage migrations service (#7902)
  Fix content type delegation to blank attachments (#8230)
  Evote bug fixing (#8220)
  Fix the proposal data migration for proposals without authors or organization (#8015)
  Bump addressable version because security issues (#8229)
  Online meetings iframe visibility with time (#8097)
  Meetings iframe and iframe URL (#8096)
  Remove flaky test on meetings (#8226)
  Fix broken tests after problematic PRs (#8224)
  Apply permissions system to comments (#8035)
  Set current_component as commentable when commentable is a participatory space (#8189)
  Fix don't require inactive authorization handlers (#8122)
  Improve metrics calculations performance (#8215)
  Fix performance issue in notification settings page (#8155)
  Active storage migration (#7598)
  Update manual installation guide in documentation (#8217)
  Load JS configuration in elections focus mode layout (#8213)
  Fix user activity pagination when there are hidden items (#8202)
  Make it possible to define SCSS settings overrides from modules (#8198)
  ...
roxanaopr pushed a commit to i-need-another-coffee/decidim that referenced this pull request Jul 29, 2021
Co-authored-by: Oriol Gual <oriol@codegram.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in-review module: elections type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants