Skip to content

Set current_component as commentable when commentable is a participatory space#8189

Merged
leio10 merged 4 commits intodevelopfrom
fix/comments_in_initiatives
Jul 21, 2021
Merged

Set current_component as commentable when commentable is a participatory space#8189
leio10 merged 4 commits intodevelopfrom
fix/comments_in_initiatives

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Jul 5, 2021 •
edited
Loading

🎩 What? Why?

This PR:

  • Allows to set commentable as current_component on CommentForm when commentable does't respond to component or participatory_space and there is a manifest declaring the commentable class as participatory space.
  • Adapts the Decidim::Resourceable concern to work with resources that don't belong to a component, like Decidim::Initiative
  • Adds the shared comment examples to initiatives and changes an example which doesn't make sense in the context of an initiative.

📌 Related Issues

Testing

As signed in user visit a published initiative. The user should be able to add new comments

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto marked this pull request as ready for review July 6, 2021 13:23
leio10
leio10 approved these changes Jul 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leio10 leio10 added module: comments type: fix PRs that implement a fix for a bug in-review labels Jul 21, 2021
@leio10 leio10 merged commit dee55df into develop Jul 21, 2021
@leio10 leio10 deleted the fix/comments_in_initiatives branch July 21, 2021 08:54
@leio10
Copy link
Copy Markdown
Contributor

leio10 commented Jul 21, 2021

Please, @entantoencuanto can you backport this to 0.24? Thanks!

@leio10 leio10 mentioned this pull request Jul 21, 2021
Merged
12 tasks
entantoencuanto added a commit that referenced this pull request Jul 21, 2021
@entantoencuanto
Set current_component as commentable when commentable is a participat…
f2e842a 
…ory space (#8189)
@entantoencuanto entantoencuanto mentioned this pull request Jul 21, 2021
Merged
12 tasks
entantoencuanto added a commit that referenced this pull request Jul 26, 2021
@entantoencuanto
Merge branch 'develop' into 7714-quilljs
e488132 
* develop: (32 commits)
  Remove obsolete rake webpack task (#8237)
  Active storage migrations service (#7902)
  Fix content type delegation to blank attachments (#8230)
  Evote bug fixing (#8220)
  Fix the proposal data migration for proposals without authors or organization (#8015)
  Bump addressable version because security issues (#8229)
  Online meetings iframe visibility with time (#8097)
  Meetings iframe and iframe URL (#8096)
  Remove flaky test on meetings (#8226)
  Fix broken tests after problematic PRs (#8224)
  Apply permissions system to comments (#8035)
  Set current_component as commentable when commentable is a participatory space (#8189)
  Fix don't require inactive authorization handlers (#8122)
  Improve metrics calculations performance (#8215)
  Fix performance issue in notification settings page (#8155)
  Active storage migration (#7598)
  Update manual installation guide in documentation (#8217)
  Load JS configuration in elections focus mode layout (#8213)
  Fix user activity pagination when there are hidden items (#8202)
  Make it possible to define SCSS settings overrides from modules (#8198)
  ...
roxanaopr pushed a commit to i-need-another-coffee/decidim that referenced this pull request Jul 29, 2021
@entantoencuanto @roxanaopr
Set current_component as commentable when commentable is a participat…
0f17558 
…ory space (decidim#8189)
@eliegaboriau eliegaboriau mentioned this pull request Nov 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@leio10 leio10 leio10 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

in-review module: comments type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments not working in Initiatives

2 participants

@entantoencuanto @leio10