Conversation
This reverts commit b8b38c8.
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
119e084 to
83c10e9
Compare
This was referenced Jun 3, 2021
ferblape
commented
Jun 24, 2021
| <head> | ||
| <title><%= decidim_page_title %></title> | ||
| <%= render partial: "layouts/decidim/head" %> | ||
| <%= render partial: "layouts/decidim/js_configuration" %> |
Contributor
Author
There was a problem hiding this comment.
I needed to move this to the head tag because when embedding an iframe it wasn't being executed, and I couldn't find the reason why. Let me know if you want me to get deeper on the reasons
8ddfc96 to
1ad1fb1
Compare
ccd3724 to
5cf83ce
Compare
70e9913 to
90aa4a5
Compare
90aa4a5 to
58e2423
Compare
entantoencuanto
added a commit
that referenced
this pull request
Jul 26, 2021
* develop: (32 commits) Remove obsolete rake webpack task (#8237) Active storage migrations service (#7902) Fix content type delegation to blank attachments (#8230) Evote bug fixing (#8220) Fix the proposal data migration for proposals without authors or organization (#8015) Bump addressable version because security issues (#8229) Online meetings iframe visibility with time (#8097) Meetings iframe and iframe URL (#8096) Remove flaky test on meetings (#8226) Fix broken tests after problematic PRs (#8224) Apply permissions system to comments (#8035) Set current_component as commentable when commentable is a participatory space (#8189) Fix don't require inactive authorization handlers (#8122) Improve metrics calculations performance (#8215) Fix performance issue in notification settings page (#8155) Active storage migration (#7598) Update manual installation guide in documentation (#8217) Load JS configuration in elections focus mode layout (#8213) Fix user activity pagination when there are hidden items (#8202) Make it possible to define SCSS settings overrides from modules (#8198) ...
roxanaopr
pushed a commit
to i-need-another-coffee/decidim
that referenced
this pull request
Jul 29, 2021
* Make questions publicable * Introduce polls in meetings model and admin management * Revert "Make questions publicable" This reverts commit b8b38c8. * Create specific question/answer models for meetings * Live event view * Manage questions in the live event page * List questions to users * Questions polling * Answer questions * Remove animations for better UI when polling * Show answers results * Export answers in the admin * Refactor and clear Ruby offenses * Normalize translations * JS offenses * ERB offenses * Force factories to create published meetings * Increase capybara wait time for ajax requests * Adjust markup to fix styles * ERB offense * Fix bad merge * Performance: remove N+1 and optimize answer options results calculation * Fix param assignment * Show validation error * Deal with nils * Fix translation Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add show iframe options in meetings * Transform iframe URL * Add embeddable logic to embed the iframe inline * Remove partial call from bad merge * Refactor conditions to reduce complexity * Move JS config to top * Refactor aspect-ratio class to prevent adding classed to child element * Update attribute meaning * Add validation message when trying to embed a meeting that can't be embedded * Always show embedded iframe if check is enabled * Cell refactor * style: fix lint issue Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> Co-authored-by: Leonardo Diez <leiodd@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR:
📌 Related Issues
Testing
As an admin check the setting is available in meeting form. Check it disappears when the meeting is physical.
Check different values in the online url: youtube, twitch, another service (jitsi?)
As a user review how the CTA block behaves with the different combinations of values:
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
The new setting available in meetings form:
The CTA updated:
The live event with questions sidebar and an iframe integrating a jitsi call: