Fix joining a meetings that the user already follows#7854
Merged
mrcasals merged 3 commits intodecidim:developfrom Apr 19, 2021
Merged
Fix joining a meetings that the user already follows#7854mrcasals merged 3 commits intodecidim:developfrom
mrcasals merged 3 commits intodecidim:developfrom
Conversation
mrcasals
approved these changes
Apr 19, 2021
entantoencuanto
added a commit
that referenced
this pull request
Apr 19, 2021
* develop: New Crowdin updates (#7850) Accessibility tool for development environments (#7810) Attempt to fix puffing-billy runtime error (#7853) Dynamically get all participatory space role tables for the `visible_meeting_for` query (#7855) Fix joining a meetings that the user already follows (#7854) Improve proposals import options (#7669) Fix proposal form attachment errors (#7856) New Crowdin updates (#7844) Fix branch name on generators (#7849) Conditionally render questions in election booth (#7822) Fix node version for version managers (#7848) Migrate to Webpacker (#7464)
microstudi
pushed a commit
to Platoniq/decidim
that referenced
this pull request
May 14, 2021
4 tasks
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Jul 13, 2021
This was referenced Jul 13, 2021
carlobeltrame
added a commit
to stadtluzern/decidim-ocl
that referenced
this pull request
Sep 28, 2021
Refs #160 Remove this once we upgrade to a decidim version that includes decidim/decidim#7854
carlobeltrame
added a commit
to stadtluzern/decidim-ocl
that referenced
this pull request
Sep 28, 2021
Refs #160 Remove this once we upgrade to a decidim version that includes decidim/decidim#7854
carlobeltrame
added a commit
to stadtluzern/decidim-ocl
that referenced
this pull request
Sep 28, 2021
Refs #160 Remove this once we upgrade to a decidim version that includes decidim/decidim#7854
Merged
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When the user tries to join a meeting that they are already following, the server will raise the following validation error:
This fixes the issue by changing the
Decidim::CreateFollowcommand to check if the user is already following the followable item before creating the follow.Testing
📋 Checklist
docs/.