Skip to content

Attempt to fix puffing-billy runtime error#7853

Merged
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/puffing-billy-runtime-error
Apr 19, 2021
Merged

Attempt to fix puffing-billy runtime error#7853
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/puffing-billy-runtime-error

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Apr 17, 2021

🎩 What? Why?

Puffing billy is still failing in occasional test runs. This is an attempt for a further fix it based on the stack trace. There's been already a few attempts before (see the related issues).

Example test run that failed:
https://github.com/decidim/decidim/runs/2370653474?check_suite_focus=true

Stack trace from the failed spec:

An error occurred in an `after(:suite)` hook.
Failure/Error: Socket.unpack_sockaddr_in(EM.get_sockname(@signature)).first

RuntimeError:
  eventmachine not initialized: evma_get_sockname
# /home/runner/work/decidim/decidim/decidim-dev/lib/decidim/dev/test/rspec_support/puffing_billy.rb:39:in `stop'
# ------------------
# --- Caused by: ---
# Timeout::Error:
#   execution expired
#   /home/runner/work/decidim/decidim/decidim-dev/lib/decidim/dev/test/rspec_support/puffing_billy.rb:39:in `stop'

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

@mrcasals mrcasals merged commit d59d360 into decidim:develop Apr 19, 2021
@ahukkanen ahukkanen deleted the fix/puffing-billy-runtime-error branch April 19, 2021 12:43
entantoencuanto added a commit that referenced this pull request Apr 19, 2021
* develop:
  New Crowdin updates (#7850)
  Accessibility tool for development environments (#7810)
  Attempt to fix puffing-billy runtime error (#7853)
  Dynamically get all participatory space role tables for the `visible_meeting_for` query (#7855)
  Fix joining a meetings that the user already follows (#7854)
  Improve proposals import options (#7669)
  Fix proposal form attachment errors (#7856)
  New Crowdin updates (#7844)
  Fix branch name on generators (#7849)
  Conditionally render questions in election booth (#7822)
  Fix node version for version managers (#7848)
  Migrate to Webpacker (#7464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants