Skip to content

Conditionally render questions in election booth#7822

Merged
mrcasals merged 11 commits intodevelopfrom
feat/booth-conditional-questions
Apr 16, 2021
Merged

Conditionally render questions in election booth#7822
mrcasals merged 11 commits intodevelopfrom
feat/booth-conditional-questions

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Apr 9, 2021 •
edited
Loading

🎩 What? Why?

Takes into account the Ballot Styles during election setup and the vote period.

  • When setting up an election, passes the ballot styles the correspondent Ballot Styles to the Bulletin Board using the new version of its gem (0.17.0)
  • In the online voting booth, renders the questions associated to the Ballot Style of the voter's Datum. When no Datum is given (e.g. in preview mode), the Ballot Style is ignore (meaning all the questions of the election are rendered).

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

conditional.questions.mov

♥️ Thank you!

@leio10 leio10 force-pushed the feat/identify-online-voter branch from 4ca91ee to 04137a3 Compare April 9, 2021 14:46
@orlera orlera force-pushed the feat/booth-conditional-questions branch from b43e886 to 01fadec Compare April 9, 2021 16:33
@orlera orlera self-assigned this Apr 9, 2021
@orlera orlera force-pushed the feat/booth-conditional-questions branch 2 times, most recently from 9f80167 to dc476f5 Compare April 12, 2021 12:58
@leio10 leio10 force-pushed the feat/identify-online-voter branch from 04137a3 to 31fff16 Compare April 13, 2021 10:13
Base automatically changed from feat/identify-online-voter to develop April 13, 2021 11:59
@orlera orlera force-pushed the feat/booth-conditional-questions branch 4 times, most recently from 365c8e1 to b588833 Compare April 14, 2021 08:39
@orlera orlera requested review from agustibr, beagleknight, leio10 and slickepinne and removed request for beagleknight and leio10 April 14, 2021 08:46
@orlera orlera force-pushed the feat/booth-conditional-questions branch from b588833 to 3ab4bb4 Compare April 14, 2021 09:22
leio10
leio10 previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! 😍 💎

@orlera orlera force-pushed the feat/booth-conditional-questions branch 2 times, most recently from 332ed7c to 04863cd Compare April 15, 2021 09:55
beagleknight
beagleknight previously approved these changes Apr 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! ✨

@leio10 leio10 added project: e-voting Barcelona City Council contract module: elections labels Apr 16, 2021
@orlera orlera force-pushed the feat/booth-conditional-questions branch from 04863cd to d7ba563 Compare April 16, 2021 12:07
@orlera orlera marked this pull request as ready for review April 16, 2021 13:24
@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Apr 16, 2021

Hi @decidim/mantainers 👋🏽 This is ready to be reviewed 🔍

@mrcasals mrcasals merged commit b5ecce4 into develop Apr 16, 2021
@mrcasals mrcasals deleted the feat/booth-conditional-questions branch April 16, 2021 13:27
entantoencuanto added a commit that referenced this pull request Apr 19, 2021
@entantoencuanto
Merge branch 'develop' into active_storage_migration
34a28b7 
* develop:
  New Crowdin updates (#7850)
  Accessibility tool for development environments (#7810)
  Attempt to fix puffing-billy runtime error (#7853)
  Dynamically get all participatory space role tables for the `visible_meeting_for` query (#7855)
  Fix joining a meetings that the user already follows (#7854)
  Improve proposals import options (#7669)
  Fix proposal form attachment errors (#7856)
  New Crowdin updates (#7844)
  Fix branch name on generators (#7849)
  Conditionally render questions in election booth (#7822)
  Fix node version for version managers (#7848)
  Migrate to Webpacker (#7464)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slickepinne slickepinne Awaiting requested review from slickepinne

4 more reviewers

@agustibr agustibr agustibr left review comments

@mrcasals mrcasals mrcasals approved these changes

@beagleknight beagleknight beagleknight left review comments

@leio10 leio10 leio10 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@orlera orlera

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@orlera @beagleknight @agustibr @leio10 @mrcasals