Skip to content

Rails 6 upgrade#7086

Closed
alecslupu wants to merge 140 commits intodecidim:developfrom
i-need-another-coffee:chore/rails-6
Closed

Rails 6 upgrade#7086
alecslupu wants to merge 140 commits intodecidim:developfrom
i-need-another-coffee:chore/rails-6

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jan 11, 2021

🎩 What? Why?

The current pull request is not delivering new functionality. It just upgrades the Decidim to a newer rails version.

📌 Related Issues

Link your PR to an issue

Testing

  1. Apply the patch
  2. The application should require the installation of rails 6
  3. Once this step is performed and the application restarted, the Rails's version of the entire application should be Rails 6.0

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

Thanks @mrcasals , @oriolgual for starting this work. @oliverbarnes for support in debugging.
♥️ Thank you!

alecslupu and others added 30 commits October 13, 2020 10:12
Bump develop to next release version
@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Feb 2, 2021

Short update here, rolled back sprockets upgrade due to faulty behavior on assets compiling...

rails aborted!
Sprockets::FileNotFound: couldn't find file 'd3' with type 'application/ecmascript-6'
Checked in these paths: 

Adding .js, .js.erb to 'application/ecmascript-6' processor, would make the frontend fail with a strange error... 'application/ecmascript-6', to which i could not find the source.

image

@andreslucena andreslucena mentioned this pull request Feb 5, 2021
@alecslupu alecslupu marked this pull request as ready for review February 5, 2021 12:54
@alecslupu
Copy link
Copy Markdown
Contributor Author

From my point of view, This can be revised and merged.
I have it already merged in my environment, and i have not seen any issues on the following :

  • Participatory Process,
  • Meetings
  • Proposals
  • Admin area

@alecslupu
Copy link
Copy Markdown
Contributor Author

@mrcasals the Generators may be failing as a result of the changes in #7271

@mrcasals
Copy link
Copy Markdown
Contributor

mrcasals commented Feb 8, 2021

@alecslupu the problem in the generators is fixed in develop by the PR you mention, I guess you need to rebase/merge develop into your branch to get them fixed?

@alecslupu
Copy link
Copy Markdown
Contributor Author

alecslupu commented Feb 8, 2021

Considering the list of the commits has reached 138, @mrcasals asked me to provide a list of hashes that can be reviewed one by one.
The list of hashes in question :

Started by @oriolgual and @mrcasals

  • b621968 Upgrade to Rails 6
  • f0c1218 Improve default behavior for background jobs
  • 488c2fa Change generators to not use webpack
  • 6f63455 Fix migrations
  • c303df4 Fix filename and remove include_relative
  • 207371c Fix class name
  • 0bac4d4 Fix filename
  • 89c01f1 Fix more class names and filenames
  • 59191f5 Fix loading for Decidim::Messaging classes
  • d0f4207 Remove require

Continued by me.

  • 2255353 Fixing Rails Autoloader
  • a6dc797 Fixing the outdated bundles
  • 889227e rails-cells 0.0.9 generates wrong number of arguments (given 0, expected 1) fixes [Rails 6] rails-cells 0.0.9 generates wrong number of arguments (given 0, expected 1) #7081
  • 0a1493c Fix: DEPRECATION WARNING: ActionView::Base instances should be constructed with a lookup context, assignments, and a controller. (called from new at /code/decidim/decidim-core/lib/decidim/diffy_extension.rb:14)
  • cdb2c4b Fix: DEPRECATION WARNING: Module#parent has been renamed to module_parent. parent is deprecated and will be removed in Rails 6.1. (called from presenter_for_author at /code/decidim/decidim-core/app/cells/decidim/coauthorships_cell.rb:55)
  • b066465 Fixing Mailer expectations
  • 869b147 Fixing more core failing tests
  • bf47672 More mailers
  • 7dc464e Fixing Survey specs
  • 44948d0 Updating decidim-elections dependencies
  • 1325f5e Fixing Capybara related issues
  • 49b488f Fix generators
  • 5066b1c Upgrade the bulletin_board gem to 0.4.0
  • 27f41b2 Freezing Rubocop-Rails version
  • 2d958e4 Lint only Rails/WhereEquals
  • 4128677 Lint only Style/StringLiterals
  • 22573d8 Lint only Layout/SpaceAroundOperators
  • d0eaa73 Various layout linters
  • 223e5f5 Linters and attempts to fix flacky test
  • 4f10c80 Adding comment as requested
  • 9238da4 Linters

@mrcasals
Copy link
Copy Markdown
Contributor

@alecslupu there's a bunch of CI jobs failing, can you check them? 😄

@alecslupu
Copy link
Copy Markdown
Contributor Author

@alecslupu there's a bunch of CI jobs failing, can you check them? smile

I checked them ... and seems that some (most) of them have failed in the setup part of the workflow ... some Github bug ...
I do not have the permissions to retriger jobs...

image

I have retrigered on i-need-another-coffee#49
image

@oliverbarnes
Copy link
Copy Markdown
Contributor

Looks like they were retriggered an hour and a half ago, and now there's actual test errors

@entantoencuanto entantoencuanto mentioned this pull request Feb 26, 2021
12 tasks
@alecslupu
Copy link
Copy Markdown
Contributor Author

closed in favor of #7471

@alecslupu alecslupu closed this Mar 9, 2021
@alecslupu alecslupu deleted the chore/rails-6 branch July 13, 2021 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants