We're still having segmentation faults with 2.7.1

I've just re-run 2 cancelled and 1 failing job

meetings tests succeeded but "proposals (system public)" crashed with Segmentation Fault again. "Proposals (system admin)" hanged again

I've run the tests locally twice and I'm not having the seg fault. I'll run the whole proposals test suite locally. I'm on Ubuntu 18.04.

The problem was probably introduced after merging #6513 (749cba3) into develop. It's when we started to have this segmentation faults.

@tramuntanal I ran bundle update rails but I see that PR updates other gems. Specially, concurrent-ruby looks suspicious... Maybe downgrading its version would help?

Yes it's an sprokets dependency. I'll give it a try

I reran one job because it got hanging (Proposals system admin ran for 6h).

@tramuntanal did you encounter any segfaults after downgrading the concurrent_ruby version?

Hi @mrcasals yes I also re-ran the workflow twice yesterday because it was hanging forever... Now it finished with a segmentation fault again, but now in actionview-5.2.4.4/lib/action_view/path_set.rbL83:

/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.4.4/lib/action_view/path_set.rb:83: [BUG] Segmentation fault at 0x0000000000000088
ruby 2.7.1p83 (2020-03-31 revision a0c7c23c9c) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0204 p:0052 s:1327 e:001325 BLOCK  /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.4.4/lib/action_view/path_set.rb:83 [FINISH]
c:0203 p:---- s:1321 e:001320 CFUNC  :each
c:0202 p:0007 s:1317 e:001316 BLOCK  /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.4.4/lib/action_view/path_set.rb:77 [FINISH]
c:0201 p:---- s:1313 e:001312 CFUNC  :each
c:0200 p:0026 s:1309 e:001308 METHOD /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.4.4/lib/action_view/path_set.rb:76
c:0199 p:0015 s:1301 e:001300 METHOD /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.4.4/lib/action_view/path_set.rb:56
c:0198 p:0007 s:1294 e:001293 METHOD /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/actionview-5.2.4.4/lib/action_view/path_set.rb:48
...

maybe we can rollback #6513 or push the upgrade to rails 6 which will require some work and delay the release of 0.23 (any other idea?). We'll comment it internally with @decidim/product

By the way, I've been trying to upgrade to Rails 6 just to see what happens, and bundler doesn't finish the Resolving dependencies part. The command was: bundle update rails jquery-tmpl-rails ransack web-console system_test_html_screenshots --jobs 4 --redownload --verbose

@oriolgual sprockets is fixed to v 3... by decidim-core but I think that rails 6 requires sprockets 4.

Yesterday I tried to upgrade to sprockets 4 (without Rails) but it requires some refactor to do in Decidim.
I'll try to tackle the upgrade to Rails 6 together with sprockets 4 but probably it's not going to be a quick thing to do.

I managed to update all the dependencies @tramuntanal!

Some guides on how to upgrade to Rails 6:

https://guides.rubyonrails.org/upgrading_ruby_on_rails.html#upgrading-from-rails-5-2-to-rails-6-0
https://fullstackheroes.com/rails/upgrade-to-rails-6/
https://www.fastruby.io/blog/rails/upgrades/upgrade-rails-from-5-2-to-6-0.html

Unrelated, but has a strategy to capture deprecation warnings that we usually don't realize we have, and might help on upgrading:

https://github.blog/2020-08-25-upgrading-github-to-ruby-2-7/

tests are failing due to a previous error in "create test app" step:

       rails  webpacker:install
rails aborted!
Don't know how to build task 'webpacker:install' (See the list of available tasks with `rails --tasks`)
/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/railties-6.0.3.3/lib/rails/commands/rake/rake_command.rb:23:in `block in perform'
/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/railties-6.0.3.3/lib/rails/commands/rake/rake_command.rb:20:in `perform'
/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/railties-6.0.3.3/lib/rails/command.rb:48:in `invoke'
/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.7.0/gems/railties-6.0.3.3/lib/rails/commands.rb:18:in `<main>'
...

I've scheduled some time today to also push on this PR

While working on this PR we've also been trying to only update concurrent-ruby in #6524 and it worked. But #6524 is in wip.

We're going to see if #6524 can be merged, and if not, we'll create a new PR with only the concurrent-ruby part that was missing in decidim-generators and see

It turns out that, as Segmentation Faults airse randomly, all tests succeeded by casuality. After merging #6524 into develop tests for the develop branch are still failing due to segmentation fault (see sortitions tests for example):

Randomized with seed 20612
/home/runner/work/decidim/decidim/vendor/bundle/ruby/2.6.0/gems/sprockets-3.7.2/lib/sprockets/http_utils.rb:74: [BUG] Segmentation fault at 0x0000000000000000
ruby 2.6.6p146 (2020-03-31 revision 67876) [x86_64-linux]

-- Control frame information -----------------------------------------------
c:0073 p:---- s:0556 e:000555 CFUNC  :find
c:0072 p:0007 s:0552 e:000551 BLOCK  /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.6.0/gems/sprockets-3.7.2/lib/sprockets/http_utils.rb:74 [FINISH]
c:0071 p:---- s:0546 e:000545 CFUNC  :each
c:0070 p:0119 s:0542 e:000541 METHOD /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.6.0/gems/sprockets-3.7.2/lib/sprockets/http_utils.rb:73
c:0069 p:0012 s:0534 e:000533 METHOD /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.6.0/gems/sprockets-3.7.2/lib/sprockets/http_utils.rb:90
c:0068 p:0035 s:0527 E:000fa0 BLOCK  /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.6.0/gems/sprockets-3.7.2/lib/sprockets/resolve.rb:127 [FINISH]
c:0067 p:---- s:0520 e:000519 CFUNC  :each
c:0066 p:0046 s:0516 E:0023a8 METHOD /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.6.0/gems/sprockets-3.7.2/lib/sprockets/resolve.rb:124
c:0065 p:0045 s:0507 e:000506 METHOD /home/runner/work/decidim/decidim/vendor/bundle/ruby/2.6.0/gems/sprockets-3.7.2/lib/sprockets/resolve.rb:108

Closing since this was more of a test.

Oh, no! @tramuntanal are you planning on working on this? It would be awesome if we could upgrade to Rails 6, since Rails 6.1 is about to be released!

@mrcasals We tried to push this PR a little bit more but got stuck with webpack configuration. There's no plan to keep working on this right now.

@tramuntanal isn't the webpacker configuration optional? Until we upgrade to Rails 6.x we'll keep having a lot of deprecation warnings, because the Rails core team doesn't seem to be fixing those warnings for 5.x series:

rails/rails#38426

Yes @mrcasals , webpacker is optional, but we got stuck either with or without webpacker. Maybe you can take restore this branch and check? we don't have time to assign to this task now, but I agree with you that we need to go to Rails 6 the sooner the better

I've restored the branch so we/someone can keep the work and dig around it. Can you describe the issues you were having @tramuntanal? 😄