Merged
Conversation
Closed
microstudi
approved these changes
Sep 21, 2020
Contributor
microstudi
left a comment
There was a problem hiding this comment.
As this only affects building process, and tests pass. I don't see any problems here.
👍
ivan-mr
approved these changes
Sep 21, 2020
Contributor
ivan-mr
left a comment
There was a problem hiding this comment.
Everything seems ok. Thanks for the upgrade!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
It's been long ago since JavaScript dependencies have not been updated and some libraries are starting to be too old. See #6523 for context.
Automatically upgrading everything results in webpack build errors so some manual version supervision should be done during the upgrading of these libraries.
📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required📷 Screenshots (optional)