Skip to content

Add the key ceremony#6967

Merged
mrcasals merged 49 commits intodevelopfrom
feat/add-key-ceremony
Jan 25, 2021
Merged

Add the key ceremony#6967
mrcasals merged 49 commits intodevelopfrom
feat/add-key-ceremony

Conversation

@beagleknight
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight commented Dec 2, 2020

🎩 What? Why?

This PR allows a trustee to generate election keys for an election he/she is a trustee for. During the key ceremony process, the trustee has to download their backup keys. When all trustees completed that step, the process continues. If one trustee leaves the page after generating the backup keys, he/she has to restore the keys to continue the process.

📌 Related Issues

Testing

GENERATING ELECTION KEYS

  1. As an admin, create two new trustees (admin@example.org and user@example.org) and set up an election with these two trustees.
  2. Go to the trustee zone for trustee 1 (Admin). You should find the election and the link Action required. Following this link, you enter the key ceremony page. Click the Start button and download theBackup keys.
  3. Go to the trustee zone for the 2nd trustee and repeat the steps above. You should see a success notification with the new election bulletin board status: ready.
  4. Click the Back button.
  5. You should see an updated list of elections, showing the new bb_status. The link Action required is no longer available. Instead, you should see No.

GENERATING ELECTION KEYS WITH RESTORING BACKUP KEYS

  1. As an admin, create two new trustees (admin@example.org and user@example.org) and set up an election with these two trustees.
  2. Go to the trustee zone for trustee 1 (Admin). You should find the election and the link Action required. Following this link, you enter the key ceremony page. Click the Start button and download theBackup keys.
  3. Leave the page, e.g. go back to the trustee zone election overview (previous page).
  4. Click Action required again.
  5. Click Start*.
  6. Upload your Backup keys.
  7. Go to the trustee zone for the 2nd trustee and repeat the steps above. You should see a success notification with the new election bulletin board status: ready.
  8. Click the Back button.
  9. You should see an updated list of elections, showing the new bb_status. The link Action required is no longer available. Instead, you should see No.

CHECKING GRAPHQL
As soon as the key ceremony is done, you can open GraphiQl (Bulletin board) and run the following query, where uniqueId is equal to your Decidim Authority (parameterized), followed by a dot and the id of the election.

query {
    election(uniqueId: "decidim-test-authority.13") {
    logEntries {
      messageId
      client {
        name
      }
      chainedHash
    }
  }
}

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Trustee zone with Elections
Trustee Zone Election Overview

Key Ceremony - Generate election keys
Trustee Zone Generate Election Keys

Key Ceremony - Backup election keys
Trustee Zone Download Backup Keys

Key Ceremony - Restore election keys
Trustee Zone Restore Election Keys

Key Ceremony - Success
Trustee Zone Key Ceremony Success

♥️ Thank you!

@andreslucena andreslucena changed the title feat(elections): add the key ceremony Add the key ceremony Dec 4, 2020
@andreslucena
Copy link
Copy Markdown
Member

Could you please fill the description template 🙏?

@beagleknight
Copy link
Copy Markdown
Contributor Author

Could you please fill the description template 🙏?

Sorry @andreslucena ! I just created this draft and @slickepinne will be working on it. We'll fill in the description soon!

@slickepinne slickepinne force-pushed the feat/add-key-ceremony branch from d05128b to 4d23423 Compare December 7, 2020 13:45
Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 40937 lines exceeds the maximum allowed for the inline comments feature.

@slickepinne slickepinne changed the base branch from develop to refactor/move-bulletin-board-client-to-bb-gem December 7, 2020 15:43
@slickepinne slickepinne force-pushed the refactor/move-bulletin-board-client-to-bb-gem branch from 94483b4 to e71233e Compare December 8, 2020 18:56
Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 40937 lines exceeds the maximum allowed for the inline comments feature.

@slickepinne slickepinne force-pushed the refactor/move-bulletin-board-client-to-bb-gem branch from dec1d9d to ccf8a77 Compare December 9, 2020 10:51
@slickepinne slickepinne force-pushed the feat/add-key-ceremony branch from 8b8a841 to 8dce277 Compare December 10, 2020 16:07
Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 40937 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 40937 lines exceeds the maximum allowed for the inline comments feature.

@leio10 leio10 added the project: e-voting Barcelona City Council contract label Dec 14, 2020
@leio10 leio10 force-pushed the refactor/move-bulletin-board-client-to-bb-gem branch from ccf8a77 to d4d51ab Compare December 14, 2020 11:55
@leio10 leio10 force-pushed the feat/add-key-ceremony branch 4 times, most recently from 8eddcfb to 71d2f56 Compare December 14, 2020 18:18
Base automatically changed from refactor/move-bulletin-board-client-to-bb-gem to develop December 15, 2020 07:14
Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 40937 lines exceeds the maximum allowed for the inline comments feature.

@leio10 leio10 force-pushed the feat/add-key-ceremony branch from 71d2f56 to 8608b07 Compare December 15, 2020 08:31
Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 41118 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 41384 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 41398 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 41447 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 41648 lines exceeds the maximum allowed for the inline comments feature.

Copy link
Copy Markdown

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 41668 lines exceeds the maximum allowed for the inline comments feature.

@leio10 leio10 dismissed stale reviews from agustibr and themself via 15d6c7d January 13, 2021 11:37
@leio10 leio10 force-pushed the feat/add-key-ceremony branch from c5ab057 to 15d6c7d Compare January 13, 2021 11:37
@mrcasals
Copy link
Copy Markdown
Contributor

@slickepinne @beagleknight watch out, there are conflicts!

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@mrcasals mrcasals merged commit f7eae0b into develop Jan 25, 2021
@mrcasals mrcasals deleted the feat/add-key-ceremony branch January 25, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create Elections keys for an Election

7 participants