Skip to content

Fix autoloading paths on GraphQL on more libraries.#7203

Merged
mrcasals merged 45 commits intodecidim:developfrom
i-need-another-coffee:feature/add-api-structure-all
Jan 22, 2021
Merged

Fix autoloading paths on GraphQL on more libraries.#7203
mrcasals merged 45 commits intodecidim:developfrom
i-need-another-coffee:feature/add-api-structure-all

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Jan 22, 2021

🎩 What? Why?

Refactor the API paths to fix some of the zeitwerk autoloader in rails6, and fix api loading on development environment.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

Bump develop to next release version
@alecslupu alecslupu mentioned this pull request Jan 22, 2021
12 tasks
@alecslupu alecslupu marked this pull request as ready for review January 22, 2021 12:31
@alecslupu alecslupu changed the title Feature/add api structure all Fix autoloading paths on GraphQL on more libraries. Jan 22, 2021
@alecslupu
Copy link
Copy Markdown
Contributor Author

@mrcasals this can be reviewed from my Point of View.

Copy link
Copy Markdown
Contributor

@mrcasals mrcasals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants