Skip to content

Fix searchable issues with resources with unexisting organization#6839

Merged
tramuntanal merged 1 commit intodecidim:developfrom
mainio:fix/issues-with-searchable-functionality
Nov 11, 2020
Merged

Fix searchable issues with resources with unexisting organization#6839
tramuntanal merged 1 commit intodecidim:developfrom
mainio:fix/issues-with-searchable-functionality

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Nov 10, 2020 •
edited
Loading

🎩 What? Why?

When there are resources in the database which are not mapped to any existing organization, the searchable classes cause issues with the "move proposals to i18n" migration.

📌 Related Issues

Testing

  • Add a resource with an unexisting component or unexisting organization to the DB
  • Try to run the "move proposals to i18n" migration

📋 Checklist

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Nov 10, 2020

The initiatives failing test is flaky, this failing check is invalid:

decidim/decidim-initiatives/spec/services/decidim/initiatives/initiative_search_spec.rb

Line 63 in 0352da1

expect(subject).to contain_exactly(initiative)

In the failing example it was searching for initiative with ID 39 which also matched with another title containing the number "39" in the title sequence as generated by factory bot.

Admin tests are jamming as usual, so they will probably be cancelled.

This was referenced Nov 11, 2020
Merged
Merged
@tramuntanal
Copy link
Copy Markdown
Contributor

tramuntanal commented Nov 11, 2020

I've re-run both workflows @ahukkanen

@tramuntanal tramuntanal self-assigned this Nov 11, 2020
tramuntanal
tramuntanal approved these changes Nov 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good

@tramuntanal tramuntanal merged commit 863151b into decidim:develop Nov 11, 2020
@tramuntanal
Copy link
Copy Markdown
Contributor

tramuntanal commented Nov 11, 2020 •
edited
Loading

Can you backport to 0.23 please @ahukkanen ?

@ahukkanen ahukkanen deleted the fix/issues-with-searchable-functionality branch November 11, 2020 08:38
ahukkanen added a commit to mainio/decidim that referenced this pull request Nov 11, 2020
@ahukkanen
Fix searchable issues with resources with unexisting organization (de…
ba78c1b 
…cidim#6839)
@ahukkanen ahukkanen mentioned this pull request Nov 11, 2020
Merged
12 tasks
@ahukkanen
Copy link
Copy Markdown
Contributor Author

ahukkanen commented Nov 11, 2020

@tramuntanal #6843

tramuntanal pushed a commit that referenced this pull request Nov 11, 2020
@ahukkanen
Fix searchable issues with resources with unexisting organization (#6839
b90d3d5 
) (#6843)
edgarlatorre pushed a commit that referenced this pull request Nov 11, 2020
@ahukkanen @edgarlatorre
Fix searchable issues with resources with unexisting organization (#6839
6815be3 
)
@mrcasals mrcasals added module: core type: fix PRs that implement a fix for a bug labels Feb 26, 2021
maintainer-partecipa pushed a commit to dipartimentofunzionepubblica/partecipa that referenced this pull request Jul 7, 2022
@Jeanluc74
soluzione al bug decidim/decidim#6839
1a71eb3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tramuntanal tramuntanal tramuntanal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tramuntanal tramuntanal

Labels

in-review module: core type: fix PRs that implement a fix for a bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ahukkanen @tramuntanal @mrcasals