Merged
Conversation
39806a2 to
886ce4c
Compare
Contributor
Author
|
@decidim/core hi! Could you review this PR please? 😄 |
aa8572d to
695ff83
Compare
Leusev
suggested changes
Jul 27, 2020
decidim-proposals/app/forms/decidim/proposals/admin/proposal_base_form.rb
Show resolved
Hide resolved
tramuntanal
approved these changes
Jul 27, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
I see that the change extended to all this modules: accountability, budgets, consultations, core, dev, meetings, proposals, sortitions. This is probably where the roots of proposals arrive 😉
Contributor
Author
|
@Leusev @tramuntanal CI is green, is there anything else required for this PR to be merged? 😄 Thanks! |
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Aug 14, 2020
* Add migration * Start fixing bugs * Fix component seed * Fix ProposalPresenter * Fix sortitions specs * Use translation helper for proposals title and body * Fix accountability tests * Fix budgets specs * Fix meetings specs * Fix core specs * Remove forgotten byebug * Fix some proposals unit tests * Fix more tests * Fix specs * Fix some admin system specs * Extract "admin filter proposals" behavior into spec file No point in this being a shared behavior, since it's only used by a single spec * Fix filtering proposals by title in the admin * Move "view proposal details from admin" behavior to spec file IT's not used anywhere, so if we move to a file we get a better way to run those specific specs * Fix systems specs * Extract "manage proposal wizard steps help texts" into spec file * Fix proposal similarity * Fix more specs * Lint files * Fix public system specs * Fix more specs * Lint files * Fix system specs * Fix consultations specs * Fix linting error
Merged
This was referenced Oct 6, 2020
This was referenced Nov 10, 2020
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR follows the spirit of #6276 in the sense that it's fixing fields so that #6127 will work as expected.
In this case, this PR makes proposals aware of i18n. It doesn't change anything else from the UI, so proposals won't be translatable from the admin yet and thus this will be invisible to the user.
📌 Related Issues
None
📋 Subtasks
📷 Screenshots (optional)
None