Fix issues with move proposal fields to i18n#6838
Conversation
|
I got this issue! I don't think people should (can?) upgrade to v0.23 before this is fixed! |
I think the intention of this PR is to be able to later perform a backport to version 0.22, right? As you say the correction should be made before advancing to version 0.23 and the PR to which is referenced to fix I think is earlier than version 0.23 |
ivan-mr
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks @ahukkanen !
|
@ivan-mr Even though #6285 merged before the 0.22 release date, I don't see this particular migration being part of the official 0.22 gem. I think the 0.22 version was cut from develop on 12 June based on this commit efc4324. #6285 was merged at the end of July. My plan was to backport only to 0.23 as it's already released. Also, according to the security document, 0.22 is no longer officially supported. Before backporting, could you @ivan-mr please check also #6839. It is related to this and needs to be backported as well. |
🎩 What? Why?
There are few noticed issues with the move proposal fields to i18n migration that seem to repeat in most older instances when trying to run the migrations:
📌 Related Issues
Testing
Try to run the migration in an instance with a proposal left by a deleted user or an instance with proposals in the database that do not follow the validation criteria.
📋 Checklist
docs/.