Fix broken notifications page due to multi-budget changes#6815
Merged
tramuntanal merged 2 commits intodecidim:developfrom Nov 6, 2020
Merged
Fix broken notifications page due to multi-budget changes#6815tramuntanal merged 2 commits intodecidim:developfrom
tramuntanal merged 2 commits intodecidim:developfrom
Conversation
This was referenced Nov 6, 2020
Merged
tramuntanal
approved these changes
Nov 6, 2020
ahukkanen
added a commit
to mainio/decidim
that referenced
this pull request
Nov 6, 2020
* Fix event paths/urls for resources with polymorphic paths * Add a test for the budgeting project comment notifications
Contributor
|
Thanks @ahukkanen can you backport to 0.23 please? |
12 tasks
Contributor
Author
|
Yes, it's already building at #6820 @tramuntanal |
tramuntanal
added a commit
that referenced
this pull request
Nov 9, 2020
…to 0.23 (#6820) * Fix broken notifications page due to multi-budget changes (#6815) * Fix event paths/urls for resources with polymorphic paths * Add a test for the budgeting project comment notifications * Ignore no-emphasis-as-header mdl rule Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
edgarlatorre
pushed a commit
that referenced
this pull request
Nov 11, 2020
* Fix event paths/urls for resources with polymorphic paths * Add a test for the budgeting project comment notifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
When notifications are created for the budgeting project comments, the notification pages are broken.
The following exception will be visible in the logs:
This is because the resource locator does not automatically work for the resources with "polymorphic" routes, e.g. in this case the budgeting project which is under a budget (and therefore the route helper is
budget_project_pathinstead).📌 Related Issues
The same issue applied to the activity feed items related to the budgeting component and this was fixed by @agustibr at this commit:
5d6cf9a
This PR applies the same fix to the notifications.
Testing
📋 Checklist
docs/.