Skip to content

Backport "Fix broken notifications page due to multi-budget changes" to 0.23#6820

Merged
tramuntanal merged 2 commits intodecidim:release/0.23-stablefrom
mainio:backport/6815
Nov 9, 2020
Merged

Backport "Fix broken notifications page due to multi-budget changes" to 0.23#6820
tramuntanal merged 2 commits intodecidim:release/0.23-stablefrom
mainio:backport/6815

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Nov 6, 2020

🎩 What? Why?

Backports the fix from #6815 to 0.23.

📌 Related Issues

Testing

See original issue.

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

* Fix event paths/urls for resources with polymorphic paths

* Add a test for the budgeting project comment notifications
@tramuntanal
Copy link
Copy Markdown
Contributor

@ahukkanen can you please add the following to no-emphasis-as-header:

exclude_rule "no-emphasis-as-header"

to solve the mdl linter problem?

@ahukkanen
Copy link
Copy Markdown
Contributor Author

@tramuntanal Done.

@tramuntanal tramuntanal merged commit 6a3e6cb into decidim:release/0.23-stable Nov 9, 2020
@ahukkanen ahukkanen deleted the backport/6815 branch November 10, 2020 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants