Fix admin logs proposal presenter#6637
Merged
tramuntanal merged 4 commits intodevelopfrom Oct 8, 2020
Merged
Conversation
Contributor
Author
|
@decidim/core can you review this, please? |
tramuntanal
reviewed
Oct 8, 2020
Contributor
tramuntanal
left a comment
There was a problem hiding this comment.
Hi @mrcasals thanks for the fix, just one quick question, I'm worried the PR may be slightly changing the behavior of the presenter
...sals/app/presenters/decidim/proposals/admin_log/value_types/proposal_title_body_presenter.rb
Show resolved
Hide resolved
…alue_types/proposal_title_body_presenter.rb Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
Contributor
Author
|
@tramuntanal thanks for taking care of the linting! The test suite is green, apart from That Meetings Test™! 😄 |
Contributor
|
We're taking care of the backport, thanks @mrcasals 👍 |
tramuntanal
added a commit
that referenced
this pull request
Oct 8, 2020
* Fix admin logs proposal preesenter * Lint code * Update decidim-proposals/app/presenters/decidim/proposals/admin_log/value_types/proposal_title_body_presenter.rb Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com> * Rubocopify Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
12 tasks
tramuntanal
added a commit
that referenced
this pull request
Oct 8, 2020
* Fix admin logs proposal preesenter * Lint code * Update decidim-proposals/app/presenters/decidim/proposals/admin_log/value_types/proposal_title_body_presenter.rb Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com> * Rubocopify Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com> Co-authored-by: Marc Riera <mrc2407@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Admin logs have problems rendering proposals afteer they were moved to i18n. This Pr fixes the problem.
📌 Related Issues
Link your PR to an issue
Testing
Create a proposal as an admin before this PR. Visit the admin logs, see it fail. USe this PR and see it properly working.
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
None