Skip to content

Backport "Fix admin logs proposal presenter" to 0.23-stable#6651

Merged
tramuntanal merged 1 commit intorelease/0.23-stablefrom
backport/fix/admin_logs_with_i18n_proposals
Oct 8, 2020
Merged

Backport "Fix admin logs proposal presenter" to 0.23-stable#6651
tramuntanal merged 1 commit intorelease/0.23-stablefrom
backport/fix/admin_logs_with_i18n_proposals

Conversation

@tramuntanal
Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal commented Oct 8, 2020

🎩 What? Why?

Backports #6637 to what's going to be 0.23.0.rc1 by cherry-picking the commit into release/0.23-stable.

📌 Related Issues

Testing

Describe the best way to test or validate your PR.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing
Description

♥️ Thank you!

@mrcasals @tramuntanal
Fix admin logs proposal presenter (#6637)
312e302 
* Fix admin logs proposal preesenter

* Lint code

* Update decidim-proposals/app/presenters/decidim/proposals/admin_log/value_types/proposal_title_body_presenter.rb

Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>

* Rubocopify

Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>
Leusev
Leusev approved these changes Oct 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Leusev Leusev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok @tramuntanal

ivan-mr
ivan-mr approved these changes Oct 8, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ivan-mr ivan-mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @tramuntanal !

@tramuntanal tramuntanal merged commit 11cb0dd into release/0.23-stable Oct 8, 2020
@tramuntanal tramuntanal deleted the backport/fix/admin_logs_with_i18n_proposals branch October 8, 2020 14:09
@oliverbarnes oliverbarnes mentioned this pull request Mar 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@mrcasals mrcasals mrcasals approved these changes

@ivan-mr ivan-mr ivan-mr approved these changes

@Leusev Leusev Leusev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tramuntanal @mrcasals @ivan-mr @Leusev