Configure Decidim Bulletin Board#6420
Conversation
bb6719a to
9e6aa87
Compare
|
@decidim/product I've some concerns about this implementation:
That's all. As you can see, in this PR I've decided to implement the simplest approach to be able to iterate over it until we find the best solution for each concern. |
9e6aa87 to
83fe972
Compare
|
I have to contradict myself but taking into account environments like Heroku that have ephemeral file systems it may be best to keep with the current implementation and pass the public key as a task parameter |
|
@leio10 I've reformated your answer (by giving a numbered alphabetical list), so it's easier to follow/discuss. What I was thinking initially regarding the key with the add_authority task is to have something like the one you have in ssh (ie Also in the future, after we have the first working implementation, we should make a step by step tutorial with examples of format, as this could be an issue. For instance in your |
|
@leio10 what's the state of this PR? |
| title: Edit election | ||
| update: Update election | ||
| index: | ||
| no_bulletin_board: There is no Bulletin Board server configured, which is needed to use this module. This task should be done by the System Administrator. |
There was a problem hiding this comment.
Can we add a link to https://github.com/decidim/decidim-bulletin-board 🙏 ?
792d9cf to
3a58692
Compare
3a58692 to
85a81cb
Compare
85a81cb to
3533b36
Compare
|
@andreslucena I've addressed your comments. Regarding the link you asked to add in the warning message, it was shown inside a callout, that wasn't prepared to show links. So, I've added some styling for that. You can check it here. |
|
@decidim/core this was approved by Product and is ready to be reviewed |
tramuntanal
left a comment
There was a problem hiding this comment.
Great work @leio10 !
| @identification_private_key_content ||= if identification_private_key.starts_with?("-----") | ||
| identification_private_key | ||
| else | ||
| File.read(Rails.application.root.join(identification_private_key)) | ||
| end |
There was a problem hiding this comment.
Good, two ways to set the private key. I see it is also documented 👏
* doc: add Bulletin Board connection setup guide * feat: add identification keys generation task * feat: include bulletin board settings in the applications generator * feat: make the bulletin board client read the connection settings * feat: warn administrator users about the missing Bulletin Board setup * refactor: move rake tasks test helpers from core to dev to reuse them * test: add tests for the rake task and the bulletin board client * style: fix lint issues * doc: apply requested changes * feat: fix style for links inside admin callouts
* Remove Markdown doc * Add documentation with Antora (AsciiDoc format - .adoc) Adds sections: * configure * customize * develop * install * services Also adds: * a README explaining the relationship with the documentation repository available in https://github.com/decidim/documentation * antora metadata file so we can build these sections in the same website * Fix Antora name for docs * Rename advanced pages to Concerns * Add Authorizations customize from module's README * Move 'add_authorizable_action' to 'permissions' * Move 'adding_fixtures_aka_dummy_content' to 'components' * Move 'how_to_create_a_module' to 'components' * Remove 'upgrading', now it's in 'update' * Install guide: fix error in 'whatever' gem (it's 'whenever') * Install guide: fix error in RAILS_ENV order in commands * Install guide: fix command for open_data export * Install guide: fix link to Contribution guide * Develop guide: add example apps * Architecture docs Add first version of c4model diagrams with PlantUML * https://c4model.com/ * https://plantuml.com/ * https://github.com/RicardoNiepel/C4-PlantUML * Add some explanation of modules types (with Components link) * Configure: ENV VARS and Initializer This moves ENV VARS configuration docs to its own page. We also create a new page for explaining Decidim's initializer settings (config/initializer/decidim.rb). For the moment is mostly a copy paste with nice formating, but the idea is to expand it. * Sync "Make maps actually configurable" by @ahukkanen Extracted from #6340 * Sync "Templates module" by @verarojman Extracted from #6247 * Sync "Configure Decidim Bulletin Board" by @leio10 Extracted from #6420 * Sync "Add a task to fix locale issues" by @microstudi Extracted from #6510 * Update versions in SECURITY.adoc * Convert CONTRIBUTING.md to AsciiDoc * Convert README.md to AsciiDoc * Clarify CONTRIBUTING and links to docs site * Remove Markdown linter CI * Sync "Update documentation for `decidim` OAuth social provider" by @tramuntanal Extracted from #6607 * Sync "Generate changelog entries" by @tramuntanal Extracted from #6794 * Fix link in oauth.adoc * Sync "Improve moderation panel" by @beagleknight Extracted from #6677 * Removes trailing whitespaces Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>

🎩 What? Why?
This PR implements the first step needed to configure a connection to a Bulletin Board from Decidim. It generates an identification pair of keys to be able to sign all the requests sent to the Bulletin Board.
📌 Related Issues
📋 Subtasks
CHANGELOGupgrade notes, if required📷 Screenshots (optional)