Improve moderation panel by beagleknight · Pull Request #6677 · decidim/decidim

beagleknight · 2020-10-14T07:39:38Z

🎩 What? Why?

This add a few improvements in the moderations panel:

Added new columns (id, created_at) and reorganise them.
Sort table by some columns (report_count and created_at)
Add filter component with search bar
Paginate moderations: side effect of using the Filterable concern.

Updated (21/10/2020)

This also adds two new views to the moderation panel:

In the moderations list you can click the "Expand" button to see more details about the moderation (see screenshot below). In this new page you can see a table with all the reports that belongs to that moderation.
In the reports table there is an excerpt of the reported content in the language that the user was using at the moment. You can also click the "Expand" button to see the whole content.

Both views includes a "preview" of the reported content. Since we don't want to display the whole content I created a new cell called reported_content_cell that can be configured for each resource. This cell will be used to preview this content in the email sent to the moderators.

Related issues/prs

Related to https://meta.decidim.org/processes/roadmap/f/122/proposals/15627 Implements the "In the moderation panel" section from the proposal exceept the part of the modal.

Testing

First report a few resources (i.e. proposals, meetings, ...)
Navigate to the admin dashboard and go to the moderations panel
Try to sort the table by report count or creation date
Filter moderations by reportable type
Search moderations by reportable id or reported content.

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

📷 Screenshots

Before:

After:

(when hovering over "Visit URL" link)

(previous screenshot when scrolling down a bit...)

mrcasals · 2020-10-14T08:03:42Z

Hi, @decidim/product can you review this PR? Here's the link:

https://decidim-staging-pr-201.herokuapp.com/

It implements part of https://meta.decidim.org/processes/roadmap/f/122/proposals/15627 (as explained in the description of this PR)

andreslucena · 2020-10-15T08:33:12Z

Can you add the before screenshots also so it's easier to see the visual diff? 🙏 🙏

beagleknight · 2020-10-15T08:42:35Z

Can you add the before screenshots also so it's easier to see the visual diff? 🙏 🙏

@andreslucena Added a before screenshot to the PR description 😄

andreslucena · 2020-10-15T09:03:18Z

@andreslucena Added a before screenshot to the PR description smile

Awesome thanks!

Could you add title column in the moderation panel?

For better understanding, id = 5 is this:

But as an administrator / moderator I can't know.

I don't know if it's on the current sprint or in another, but a common need is to be able to see the moderated content after it was moderated. Is that going to be developed by you guys?

Also, nice to see you here again @beagleknight 😄

beagleknight · 2020-10-15T10:24:47Z

Could you add title column in the moderation panel?

We are currently developing a "show" view for each moderation that includes more info related to the reportable object. I'm not sure if that's enough 😄 // cc @mrcasals

Also, nice to see you here again @beagleknight 😄

👋 I am glad to work with you again @andreslucena !

mrcasals · 2020-10-21T14:04:51Z

@decidim/product we've updated the PR with more additions. Check the updated description, and check the Review App:

https://decidim-staging-pr-205.herokuapp.com/

virgile-dev · 2020-10-22T11:22:47Z

@mrcasals Hey Marc,
Adding the things that we commented by email.

Direct link to conversation with author (group conversation if multiple authors) in the moderation reports
Hide "Reported content" column as its redundant with content details in the "Moderation reports" view
Add tooltip when hovering overing on type with an abstract of the content (title for debate, proposal, meetings, body for comment (first 1sts 150 characters) --> (Still in discussion, maybe adding an abstract column is better, my main concern is that lots of the moderation work is skimming throught the table and hide the most problematic concern)

mrcasals · 2020-10-22T12:39:01Z

@virgile-dev all these changes should be deployed to the staging app now:

https://decidim-staging-pr-205.herokuapp.com/admin/participatory_processes/atque-rerum/moderations

tramuntanal

Hi @beagleknight ,
good job here!
I just suggest for a renaming.
Also, can you add a little bit of documentation in docs/advanced regarding how to add make a resource reportable?

decidim-core/lib/decidim/resource_manifest.rb

mrcasals · 2020-10-27T15:55:03Z

@tramuntanal can you rereview it, please? 😄

tramuntanal

I think some unexpected contents got through the reportable.md documentation

docs/advanced/reportable.md

tramuntanal

There's still some content to be cleaned, also can you check the codecov/patch?

tramuntanal · 2020-10-28T14:22:47Z

docs/advanced/reportable.md

+To render this button, `decidim-core` offers the `decidim/reported_content` cell. It is strongly recommended to use this cell to make new resources endorsable.
+
+```ruby
+cell("decidim/endorsement_buttons", resource)
+```


This still don't belongs here

@tramuntanal This is it's good for real 🙇

Also added a couple of test to increase coverage.

tramuntanal

Thanks @beagleknight !

Extracted from #6677

@ahukkanen

* Remove Markdown doc * Add documentation with Antora (AsciiDoc format - .adoc) Adds sections: * configure * customize * develop * install * services Also adds: * a README explaining the relationship with the documentation repository available in https://github.com/decidim/documentation * antora metadata file so we can build these sections in the same website * Fix Antora name for docs * Rename advanced pages to Concerns * Add Authorizations customize from module's README * Move 'add_authorizable_action' to 'permissions' * Move 'adding_fixtures_aka_dummy_content' to 'components' * Move 'how_to_create_a_module' to 'components' * Remove 'upgrading', now it's in 'update' * Install guide: fix error in 'whatever' gem (it's 'whenever') * Install guide: fix error in RAILS_ENV order in commands * Install guide: fix command for open_data export * Install guide: fix link to Contribution guide * Develop guide: add example apps * Architecture docs Add first version of c4model diagrams with PlantUML * https://c4model.com/ * https://plantuml.com/ * https://github.com/RicardoNiepel/C4-PlantUML * Add some explanation of modules types (with Components link) * Configure: ENV VARS and Initializer This moves ENV VARS configuration docs to its own page. We also create a new page for explaining Decidim's initializer settings (config/initializer/decidim.rb). For the moment is mostly a copy paste with nice formating, but the idea is to expand it. * Sync "Make maps actually configurable" by @ahukkanen Extracted from #6340 * Sync "Templates module" by @verarojman Extracted from #6247 * Sync "Configure Decidim Bulletin Board" by @leio10 Extracted from #6420 * Sync "Add a task to fix locale issues" by @microstudi Extracted from #6510 * Update versions in SECURITY.adoc * Convert CONTRIBUTING.md to AsciiDoc * Convert README.md to AsciiDoc * Clarify CONTRIBUTING and links to docs site * Remove Markdown linter CI * Sync "Update documentation for `decidim` OAuth social provider" by @tramuntanal Extracted from #6607 * Sync "Generate changelog entries" by @tramuntanal Extracted from #6794 * Fix link in oauth.adoc * Sync "Improve moderation panel" by @beagleknight Extracted from #6677 * Removes trailing whitespaces Co-authored-by: Oliver Valls <199462+tramuntanal@users.noreply.github.com>

mrcasals mentioned this pull request Oct 14, 2020

Review app for feat/moderation-panel-improvements codegram/decidim-staging#201

Closed

Leusev changed the title ~~feat: moderation panel improvements~~ Improve moderation panel Oct 14, 2020

beagleknight added 11 commits October 20, 2020 15:00

feat: add extra columns to the moderation panel

a77aed8

feat: sort moderations by report count and creation date

3a213ff

test: prevent random failures not using random numbers

71a3e28

feat: filter moderations by reportable type

8b6599a

chore: add reported_content to moderations migration

64baac3

feat: filter moderations by reportable id or reported content

0bf3f76

feat: update reported content when a report is created

66c2d83

feat: add pagination links

a22f349

chore: fix some minor problems

0929102

refactor: simplify Reportable concern API methods

de49e60

fix: rubocop issues and test using old method

459dc22

beagleknight force-pushed the feat/moderation-panel-improvements branch from c183f99 to 459dc22 Compare October 20, 2020 13:05

beagleknight added 9 commits October 21, 2020 15:55

feat: store report's locale

391ea24

feat: add reported content cell

e7f01be

chore(proposals): add reported content cell

82ae69e

chore(meetings): add reported content cell

550acf3

chore(debates): add reported content cell

f1ac421

feat: add reports index and show for moderations panel

426058c

chore: rubocop and eslint fixes

1b43922

chore: normalize decidim-admin locales

41d2429

chore: fix some erb linter problems

61e7ed8

mrcasals mentioned this pull request Oct 21, 2020

Review app for feat/moderation-panel-improvements codegram/decidim-staging#205

Closed

beagleknight added 3 commits October 22, 2020 12:29

feat: render reportable authors with conversation links

c438a56

feat: show reportable excerpt on hover

1a34760

chore: fix codeclimate issues

3fd3f40

tramuntanal added the in-review label Oct 27, 2020

tramuntanal self-assigned this Oct 27, 2020

tramuntanal suggested changes Oct 27, 2020

View reviewed changes

decidim-core/lib/decidim/resource_manifest.rb Outdated Show resolved Hide resolved

Andrea Orler added 3 commits October 27, 2020 15:54

chore: rename reported_content_cell

914636e

chore: add docs

1652c69

fix: md styles

fa0edfe

tramuntanal suggested changes Oct 28, 2020

View reviewed changes

docs/advanced/reportable.md Outdated Show resolved Hide resolved

docs: remove non-pertinent content

47d2f8e

tramuntanal suggested changes Oct 28, 2020

View reviewed changes

Andrea Orler added 2 commits October 29, 2020 09:46

fix: docs

dc8cf2a

test: add tests for reported content cells

85aa93f

tramuntanal approved these changes Oct 30, 2020

View reviewed changes

tramuntanal merged commit 0e0e369 into decidim:develop Oct 30, 2020

mrcasals deleted the feat/moderation-panel-improvements branch November 4, 2020 13:57

andreslucena added a commit that referenced this pull request Nov 17, 2020

Sync "Improve moderation panel" by @beagleknight

560e11a

Extracted from #6677

andreslucena added a commit that referenced this pull request Nov 19, 2020

Sync "Improve moderation panel" by @beagleknight

c4f6b4c

Extracted from #6677

mrcasals added module: admin module: core module: debates module: meetings module: proposals type: feature labels Feb 26, 2021

oliverbarnes mentioned this pull request Mar 16, 2021

Bump the module and the demo to Decidim 0.23 liquidvotingio/decidim-module-liquidvoting#33

Closed

Uh oh!

Conversation

beagleknight commented Oct 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

Related issues/prs

Testing

📋 Checklist

📷 Screenshots

Uh oh!

mrcasals commented Oct 14, 2020

Uh oh!

andreslucena commented Oct 15, 2020

Uh oh!

beagleknight commented Oct 15, 2020

Uh oh!

andreslucena commented Oct 15, 2020

Uh oh!

beagleknight commented Oct 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrcasals commented Oct 21, 2020

Uh oh!

virgile-dev commented Oct 22, 2020

Uh oh!

mrcasals commented Oct 22, 2020

Uh oh!

tramuntanal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mrcasals commented Oct 27, 2020

Uh oh!

tramuntanal left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tramuntanal left a comment

Choose a reason for hiding this comment

Uh oh!

tramuntanal Oct 28, 2020

Choose a reason for hiding this comment

Uh oh!

orlera Oct 29, 2020

Choose a reason for hiding this comment

Uh oh!

tramuntanal left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

beagleknight commented Oct 14, 2020 •

edited

Loading

beagleknight commented Oct 15, 2020 •

edited

Loading