Identifying translatable fields in meetings and comments#6333
Merged
tramuntanal merged 3 commits intodecidim:feat/machine-translationfrom Jul 29, 2020
Merged
Conversation
mrcasals
approved these changes
Jul 27, 2020
4ae9f10 to
5cbf1c3
Compare
Contributor
|
Hi @anaghavl can you link in the description from where this PR comes from please? By the way, you have conflicts, thanks for checking 😃 |
ffea7d8 to
6d8bb5e
Compare
Contributor
Author
Sorry, done and done 😅 |
Contributor
|
@tramuntanal @Leusev all green now, can you re-review it please? 😄 |
5cbf1c3 to
6cd43aa
Compare
6d8bb5e to
db00c28
Compare
Contributor
|
I've re-run tests for 6 workflows that got stuck. Take into account that there are problems with GitHub Actions https://github.community/t/jobs-randomly-hanging-at-starting-your-workflow-run/124295/7, we must supervise that all tests execute in our PR and re-run the hanging ones until github solves it |
Contributor
|
@tramuntanal thanks for taking care of this! It should be all green though, can you review it please? 😄 |
Contributor
|
@tramuntanal all green now! 😄 |
tramuntanal
approved these changes
Jul 29, 2020
mrcasals
added a commit
that referenced
this pull request
Aug 14, 2020
* Base branch * remove file * Idenifying translatable fields in meetings and comments Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>
mrcasals
added a commit
that referenced
this pull request
Aug 14, 2020
* Base branch * remove file * Idenifying translatable fields in meetings and comments Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>
tramuntanal
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Base branch * remove file * Base branch * remove file * Identify translatable resources (#6145) * Base branch * remove file * Require confirmation on exiting a survey mid-answering (#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> * Add Decidim global and organization config for machine translation (#6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com> * Identifying translatable fields in meetings and comments (#6333) * Base branch * remove file * Idenifying translatable fields in meetings and comments Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> * Identifying translatable fields for proposals (#6346) * Add machine translation service (#6179) Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Marc Riera <mrc2407@gmail.com> * Make some fields non-translatable * Improve spec * Don't run job if class is not defined * Improvee method naming * Machine translation display priority (#6385) * Add docs on how to enable the integration * Add docs on how to write a machine translation service * Improve code strength * Fix specs * Fix specs Co-authored-by: anagha vl <44900292+anaghavl@users.noreply.github.com> Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #6127,
Applied
TranslatableResourceto meetings and comments.