Add Decidim global and organization config for machine translation#6128
Merged
tramuntanal merged 10 commits intodecidim:feat/machine-translationfrom Jul 20, 2020
Merged
Add Decidim global and organization config for machine translation#6128tramuntanal merged 10 commits intodecidim:feat/machine-translationfrom
tramuntanal merged 10 commits intodecidim:feat/machine-translationfrom
Conversation
* New translations en.yml (French) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian)
mrcasals
commented
May 26, 2020
decidim-generators/lib/decidim/generators/app_templates/initializer.rb
Outdated
Show resolved
Hide resolved
mrcasals
commented
May 26, 2020
decidim-admin/app/views/decidim/admin/organization/_form.html.erb
Outdated
Show resolved
Hide resolved
This reverts commit e66e49a.
Contributor
|
@mrcasals can you review? |
5 tasks
Contributor
Author
|
@anaghavl Linter is complaining, can you check it please? Note you can automatically fix it running |
c8fe241 to
513b8f2
Compare
Contributor
Author
|
@decidim/core please, could we get this reviewed? More context for this PR can be found at #6127 |
microstudi
requested changes
Jun 3, 2020
Contributor
microstudi
left a comment
There was a problem hiding this comment.
I understand that this is only to enable/disable the option for machine translation.
There's no tests in here, will they be included later on?
in the file update_organization_spec.rb the property rich_text_editor_in_public_views is checked, maybe this one could be added too.
In any case, It seems that you've added an empty file called test, can you remove it please?
Contributor
|
Hi @mrcasals there's this PR pending since @microstudi 's review. Do you plan to work on in soon? |
Contributor
Author
|
@tramuntanal sorry, this slipped through my filters and forgot about it. @anaghavl can you check @microstudi's comments please? 😄 |
Contributor
|
@mrcasals Sorry, this slipped through my emails too. |
Contributor
Author
|
Yay! @decidim/core can you review this again please? 😄 |
anaghavl
added a commit
that referenced
this pull request
Jul 23, 2020
…6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>
anaghavl
added a commit
that referenced
this pull request
Jul 27, 2020
…6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>
anaghavl
added a commit
that referenced
this pull request
Jul 28, 2020
…6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>
mrcasals
added a commit
that referenced
this pull request
Aug 14, 2020
…6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>
mrcasals
added a commit
that referenced
this pull request
Aug 14, 2020
…6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>
tramuntanal
pushed a commit
that referenced
this pull request
Aug 17, 2020
* Base branch * remove file * Base branch * remove file * Identify translatable resources (#6145) * Base branch * remove file * Require confirmation on exiting a survey mid-answering (#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> * Add Decidim global and organization config for machine translation (#6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com> * Identifying translatable fields in meetings and comments (#6333) * Base branch * remove file * Idenifying translatable fields in meetings and comments Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> * Identifying translatable fields for proposals (#6346) * Add machine translation service (#6179) Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Marc Riera <mrc2407@gmail.com> * Make some fields non-translatable * Improve spec * Don't run job if class is not defined * Improvee method naming * Machine translation display priority (#6385) * Add docs on how to enable the integration * Add docs on how to write a machine translation service * Improve code strength * Fix specs * Fix specs Co-authored-by: anagha vl <44900292+anaghavl@users.noreply.github.com> Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)