Identify translatable resources by anaghavl · Pull Request #6145 · decidim/decidim

anaghavl · 2020-06-02T08:37:19Z

Wrote a concern to list all the translatable fields.
Added the concern to all the models that have translatable fields.
This list can be used to verify,
jsonb.txt

I'm not sure about these:
I have skipped decidim_components - :settings, :permissions
I couldn't find models for decidim_surveys_survey_answer_options, decidim_surveys_survey_questions.

Related to Feature: Machine translation for user-generated content #6127

📋 Subtasks

mrcasals · 2020-06-03T06:39:26Z

@anaghavl I see a bunch of commits that should not be here, can you check them? I think you should rebasee against the feat/machine-translation branch 😄

* Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account

…im#6118)" This reverts commit bdeb933.

This reverts commit 2565dbb.

This reverts commit 2a09cc4.

mrcasals

Yay, nice job!

mrcasals · 2020-06-08T07:58:03Z

I have skipped decidim_components - :settings, :permissions

That's fine, these are filled in by the administrators so no need to worry about those.

I couldn't find models for decidim_surveys_survey_answer_options, decidim_surveys_survey_questions.

Mh, these tables shouldn't exist, maybe they're leftovers... 🤔 I'll open an issue!

@decidim/core Hi! Can you review this PR please? 😄 Context is on the parent PR (see #6127)!

jesusdb

Great!

* Base branch * remove file * Require confirmation on exiting a survey mid-answering (#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>

* Base branch * remove file * Require confirmation on exiting a survey mid-answering (decidim#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (decidim#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>

* Base branch * remove file * Require confirmation on exiting a survey mid-answering (#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>

* Base branch * remove file * Require confirmation on exiting a survey mid-answering (decidim#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (decidim#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>

* Base branch * remove file * Require confirmation on exiting a survey mid-answering (#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com>

* Base branch * remove file * Base branch * remove file * Identify translatable resources (#6145) * Base branch * remove file * Require confirmation on exiting a survey mid-answering (#6118) * Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account * WIP adding concern * Adding concern in all the models which have translatable fields * removed :extended_data as translatable field * WIP adding concern * Adding concern in all the models which have translatable fields * Revert "Require confirmation on exiting a survey mid-answering (#6118)" This reverts commit bdeb933. * Revert "remove file" This reverts commit 2565dbb. * Revert "Base branch" This reverts commit 2a09cc4. Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> * Add Decidim global and organization config for machine translation (#6128) * Adding setting to organizations table and creating global config * Adding config accessor to core.rb * Base branch * Added a check to display machine translation settings and changed initializer value * Fixing lint issue in migration file * Adding test and removing test file Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com> * Identifying translatable fields in meetings and comments (#6333) * Base branch * remove file * Idenifying translatable fields in meetings and comments Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> * Identifying translatable fields for proposals (#6346) * Add machine translation service (#6179) Co-authored-by: Marc Riera Casals <mrc2407@gmail.com> Co-authored-by: Marc Riera <mrc2407@gmail.com> * Make some fields non-translatable * Improve spec * Don't run job if class is not defined * Improvee method naming * Machine translation display priority (#6385) * Add docs on how to enable the integration * Add docs on how to write a machine translation service * Improve code strength * Fix specs * Fix specs Co-authored-by: anagha vl <44900292+anaghavl@users.noreply.github.com> Co-authored-by: decidim-bot <decidim-bot@users.noreply.github.com> Co-authored-by: anagha <anagha1996@gmail.com>

anaghavl changed the title ~~WIP adding concern~~ Identify translatable resources Jun 2, 2020

anaghavl changed the title ~~Identify translatable resources~~ [WIP]Identify translatable resources Jun 2, 2020

anaghavl changed the title ~~[WIP]Identify translatable resources~~ Identify translatable resources Jun 2, 2020

anaghavl requested a review from mrcasals June 2, 2020 20:01

anaghavl changed the base branch from develop to feat/machine-translation June 3, 2020 05:25

anaghavl changed the base branch from feat/machine-translation to develop June 3, 2020 05:26

anaghavl changed the base branch from develop to feat/machine-translation June 3, 2020 06:24

anaghavl force-pushed the feat/machine-translation branch from c8fe241 to 513b8f2 Compare June 3, 2020 08:51

mrcasals and others added 8 commits June 3, 2020 14:23

Base branch

2a09cc4

remove file

2565dbb

Require confirmation on exiting a survey mid-answering (decidim#6118)

bdeb933

* Require confirmation on exit * Add specs * Use path instead of url * Fix changelog * Trigger build * Fix expected path on test * Fix method call * Take textareas and selects into account

WIP adding concern

1f68c17

Adding concern in all the models which have translatable fields

98ebd02

removed :extended_data as translatable field

9b3ba84

WIP adding concern

be2fa35

Adding concern in all the models which have translatable fields

e2b31b2

anaghavl force-pushed the identify_translatable_resources branch from c72001e to e2b31b2 Compare June 3, 2020 08:57

anaghavl added 3 commits June 3, 2020 14:36

Revert "Require confirmation on exiting a survey mid-answering (decid…

da1a488

…im#6118)" This reverts commit bdeb933.

Revert "remove file"

d168ddd

This reverts commit 2565dbb.

Revert "Base branch"

be0028c

This reverts commit 2a09cc4.

mrcasals approved these changes Jun 3, 2020

View reviewed changes

mrcasals mentioned this pull request Jun 8, 2020

Surveys tables in DB not backed by models #6162

Closed

Leusev requested a review from jesusdb June 8, 2020 09:32

Leusev added the in-review label Jun 8, 2020

Leusev assigned jesusdb Jun 8, 2020

jesusdb approved these changes Jun 22, 2020

View reviewed changes

jesusdb merged commit b3abd50 into decidim:feat/machine-translation Jun 22, 2020

armandfardeau mentioned this pull request Dec 27, 2023

[Snyk] Security upgrade axios from 0.18.1 to 1.6.3 OpenSourcePolitics/decidim#1208

Open

berez23 mentioned this pull request Dec 27, 2023

[Snyk] Security upgrade axios from 0.18.0 to 1.6.3 berez23/decidim#6

Open

berez23 mentioned this pull request Jan 5, 2024

[Snyk] Security upgrade axios from 0.18.0 to 1.6.4 berez23/decidim#8

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Identify translatable resources#6145

Identify translatable resources#6145
jesusdb merged 11 commits intodecidim:feat/machine-translationfrom
codegram:identify_translatable_resources

anaghavl commented Jun 2, 2020 •

edited by mrcasals

Loading

Uh oh!

mrcasals commented Jun 3, 2020

Uh oh!

mrcasals left a comment

Uh oh!

mrcasals commented Jun 8, 2020

Uh oh!

jesusdb left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

anaghavl commented Jun 2, 2020 • edited by mrcasals Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📋 Subtasks

Uh oh!

mrcasals commented Jun 3, 2020

Uh oh!

mrcasals left a comment

Choose a reason for hiding this comment

Uh oh!

mrcasals commented Jun 8, 2020

Uh oh!

jesusdb left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anaghavl commented Jun 2, 2020 •

edited by mrcasals

Loading