Undo geocoder upgrade, we must wait for leaflet-tilelayer-here#5664
Undo geocoder upgrade, we must wait for leaflet-tilelayer-here#5664tramuntanal merged 3 commits intomasterfrom
Conversation
There's and open issue to support the new Here API's api_key: https://gitlab.com/IvanSanchez/Leaflet.TileLayer.HERE/issues/3.
microstudi
left a comment
There was a problem hiding this comment.
I think we should take over the library and add it directly Decidim.
https://gitlab.com/IvanSanchez/Leaflet.TileLayer.HERE/blob/master/leaflet-tilelayer-here.js
Last commit is 3 years old, and it's quite simple. Otherwise I fear is unmaintained.
|
With the current I suggest changing the dependency to this: s.add_dependency "geocoder", "~> 1.5.2"And release a patch version. This way Also, after upgrading to geocoder 1.6 some configuration needs to be changed: |
|
You're right. We will need to address soon the leaflet issue anyway, we might add the geocoder configuration upgrade in the same task. |
|
Please note that until you fix this, any new Decidim app will install geocoder 1.6, but since the configuration will be outdated the geocoding service will not work if we use Here.com as a provider. |
microstudi
left a comment
There was a problem hiding this comment.
We should do what @mrcasals said, bundle update needed
|
Thanks @microstudi and @mrcasals we already have #5644 on the way... and waiting... |
|
@tramuntanal but #5644 is blocked until leaflet is fixed, right? I'm suggesting merging this one (#5664) so that geocoding keeps working until #5644 is merged 😄 |
|
Upgrading apps to 0.20 keeps generating problems, because it updates |
|
Alternatively, could you port this fix to the |
* To upgrade geocoder we must wait for leaflet-tilelayer-here There's and open issue to support the new Here API's api_key: https://gitlab.com/IvanSanchez/Leaflet.TileLayer.HERE/issues/3. * Force geocoder version to increase only between v1.5 patches
* Undo geocoder upgrade, we must wait for leaflet-tilelayer-here (#5664) * To upgrade geocoder we must wait for leaflet-tilelayer-here There's and open issue to support the new Here API's api_key: https://gitlab.com/IvanSanchez/Leaflet.TileLayer.HERE/issues/3. * Force geocoder version to increase only between v1.5 patches * Add changelog entry Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
🎩 What? Why?
To upgrade geocoder we must wait for leaflet-tilelayer-here.
The partial
geocoderupgrade done in commit 05f69836e8f9db5843c7a6b12f29bbe917216f3a must be undone because Decidim must wait untilleaflet's Here plugin also supports the new Here maps API.There's already an open issue in this plugin to support the new Here API's api_key:
https://gitlab.com/IvanSanchez/Leaflet.TileLayer.HERE/issues/3.
There's already a blocked PR in Decidim to finish the upgrade: #5644
Until leaflet also supports the new Here API, Decidim must keep on using the old
app_idandapp_code.📌 Related Issues
📋 Subtasks
CHANGELOGentry