Skip to content

Lock geocoder version#5815

Merged
tramuntanal merged 2 commits into0.20-stablefrom
backport/downgrade/geocoder-must_wait_leaflet_upgrade
Mar 6, 2020
Merged

Lock geocoder version#5815
tramuntanal merged 2 commits into0.20-stablefrom
backport/downgrade/geocoder-must_wait_leaflet_upgrade

Conversation

@mrcasals
Copy link
Copy Markdown
Contributor

@mrcasals mrcasals commented Mar 3, 2020

🎩 What? Why?

This PR backports #5664 to the 0.20-stable branch, so that it can be merge and we can prepare a 0.20.1 version eventually.

📌 Related Issues

📋 Subtasks

None

* To upgrade geocoder we must wait for leaflet-tilelayer-here

There's and open issue to support the new Here API's api_key:
https://gitlab.com/IvanSanchez/Leaflet.TileLayer.HERE/issues/3.

* Force geocoder version to increase only between v1.5 patches
@mrcasals mrcasals requested a review from tramuntanal March 3, 2020 08:19
@mrcasals mrcasals self-assigned this Mar 3, 2020
@mrcasals mrcasals changed the title Undo geocoder upgrade, we must wait for leaflet-tilelayer-here (#5664) Undo geocoder upgrade Mar 3, 2020
@mrcasals mrcasals changed the title Undo geocoder upgrade Lock geocoder version Mar 3, 2020
@mrcasals mrcasals added the backport Pull Requests that are a backport for a fixed bug label Mar 3, 2020
@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Mar 3, 2020

@decidim/core can you review this? Feel free to modify whatever's needed if you feel it necessary, this is just to remove wome workload from you! 😄

Copy link
Copy Markdown
Contributor

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @mrcasals

@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Mar 5, 2020

Thank you, @tramuntanal! I wasn't sure whether you'd want the changelog entry or not so I skipped, I should have added it 🙈

@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Mar 6, 2020

@tramuntanal this PR is green! Should we merge this? (I did this so it was easy for you to create a v0.20.1 version)

@tramuntanal tramuntanal merged commit f78aea0 into 0.20-stable Mar 6, 2020
@tramuntanal tramuntanal deleted the backport/downgrade/geocoder-must_wait_leaflet_upgrade branch March 6, 2020 11:23
@tramuntanal
Copy link
Copy Markdown
Contributor

We'll release v0.20.1 version during the begining of next week. Is it ok for you?

@mrcasals
Copy link
Copy Markdown
Contributor Author

mrcasals commented Mar 6, 2020

@tramuntanal sure, thanks!

@mrcasals
Copy link
Copy Markdown
Contributor Author

Hi @tramuntanal! Could you release v0.20.1 please? Otherwise v0.20.0 keeps installing the wrong geocoder version 😞

@tramuntanal
Copy link
Copy Markdown
Contributor

I'll try to release today or in the following days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Pull Requests that are a backport for a fixed bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants