Skip to content

Use the Here lookup with the new Here url and the new authentication method#1430

Merged
alexreisner merged 4 commits intoalexreisner:masterfrom
stephanpavlovic:master
Dec 15, 2019
Merged

Use the Here lookup with the new Here url and the new authentication method#1430
alexreisner merged 4 commits intoalexreisner:masterfrom
stephanpavlovic:master

Conversation

@stephanpavlovic
Copy link
Copy Markdown
Contributor

No description provided.

@alexreisner
Copy link
Copy Markdown
Owner

This looks good, but as I just mentioned in #1429, I don't think there's any need to keep the app_id stuff around. (If someone hasn't switched to the new format yet, they can stick with a Geocoder version that supports the old format.)

@stephanpavlovic stephanpavlovic changed the title Offer the option to use the Here lookup with the new Here url and the new authentication method Use the Here lookup with the new Here url and the new authentication method Dec 15, 2019
@stephanpavlovic
Copy link
Copy Markdown
Contributor Author

Alright, I removed the app_id stuff

@alexreisner alexreisner merged commit 773ac0f into alexreisner:master Dec 15, 2019
@alexreisner
Copy link
Copy Markdown
Owner

Thanks! Looks great. Merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants