Upgrade Rails to 5.2 by deivid-rodriguez · Pull Request #3225 · decidim/decidim

deivid-rodriguez · 2018-04-15T16:14:13Z

🎩 What? Why?

While working on some managed users features and refactorings, I started running once again into rspec/rspec-rails#1887. It's a very annoying issue, and I was doing step by step refactoring and thus running the tests very often.. . It was unclear to me whether the fix was provided in Rails 5.2 or capybara 3.0, so I upgraded both :)

When pushing the branch with the upgrades, I run into some flakies, the classic "server timeout on the first test". I decided to investigate.

Those flakies usually mean that sprockets-rails is precompiling the assets on the fly in the first request and that took too long. There's something weird going on in there because I thought by precompiling the assets in the build_test_app job and sharing the precompiled assets with the other jobs we should be avoiding exactly that. But those flakies are there, so assuming they're due to asset precompilation (I've never seen other situation that affects only the first request of a test run), that means something is not happening as we expect.

To fix it, I chose to prevent that on the fly asset precompilation from happening. By doing that, we should fix the flakies but also:

We no longer need the asset precompilation on the build_test_app job. Since that job is the most bottlenecking one of all, that means around 1min savings for every build!
We no longer precompile assets on the development environment either. That means fast page loading on the first request of a freshly created development app!

📌 Related Issues

Related to Master is too unstable #3218.

📋 Subtasks

Add CHANGELOG entry
Another subtask

📷 Screenshots (optional)

None.

mrcasals · 2018-04-16T07:04:33Z

decidim-core/lib/tasks/decidim_tasks.rake

+  task upgrade: [:choose_target_plugins, :"railties:install:migrations"]
+
+  desc "Setup environment so that only decidim migrations are installed."
+  task :choose_target_plugins do


I'm not sure about this change. If we're supporting Rails 5.2 now, shouldn't we allow the ActiveStorage migrations to be installed? 😕

The original intent of decidim:upgrade was to only upgrade decidim. Maybe we could explicitly add the ActiveStorage ones (or write some instructions on the upgrade guide) once we make use of them, but I think it's fine the way it is now.

Maybe I'm missing something, what these (specific) changes have to do with ActiveStorage?

Hei! The thing is that this activestorage plugin is shipped as an engine with its own migrations. And this task was previously installing all migrations from all available engines (thus including activestorage ones).

I agree with @josepjaume's comment, but the real motivation for this change is not correctness or saving a couple of unused tables. Without this, I was not able to add new migrations to the test app, it would spit errors related to activestorage tables, not sure why...

josepjaume

Mega nice! I'd leave this for the 0.12 version though 👍

deivid-rodriguez · 2018-04-16T10:04:29Z

@josepjaume Good call, but I think I can extract the CI speed up to a separate PR since that's low risk and we can benefit from that right now. Sounds good?

mrcasals · 2018-04-16T10:09:10Z

@deivid-rodriguez sounds good to me!

mrcasals · 2018-05-08T07:21:41Z

@deivid-rodriguez we'll wait a little bit more before merging this, if you don't mind. On May 17th we have a big demo of Decidim, and it was decided to generate the lesser entropy possible until that date...

Sorry about that!

deivid-rodriguez · 2018-05-08T18:30:49Z

@mrcasals No problem! My main interest in this PR is that tests hang whenever I click Ctrl-C during a test run, and that's fixed in capybara 3.0. I found a way to upgrade to use capybara 3.0 without having to upgrade to 5.2 (it requires the test app to use the latest, unreleased, 5-1-stable branch from rails though). Is that acceptable for master at the moment?

So will you be generating an application from master for that big demo? You naughty boys & girls 😄 ...

mrcasals · 2018-05-09T07:05:21Z

@deivid-rodriguez I've merged #3361! 😄

mrcasals · 2018-05-23T08:49:55Z

@deivid-rodriguez this is not being blocked anymore! Do you need anything from us here? (reviews apart)

* Bootsnap is require in `config/boot.rb` of the default generated application, so we need to add it to the Gemfile. * Surveys were calling `save!` on `destroy!`'ed records, that's (understandably) no longer valid and was only working by chance. * A transaction block inside `Decidim.traceable` was no longer returning its last statement, so I needed to add a explicit return. I also removed a nested transaction block that seemed unnecessary. * Upgraded papertrail and fixed a deprecation warning about `whodunnit`. * Oauth's request env no longer has indifferent access. Apparently.

Like the following, or similar: ``` DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "name->'en' ASC". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql(). (called from index at /path/to/decidim-admin/app/controllers/decidim/admin/scopes_controller.rb:13) ```

This is necessary to ignore activestorage ones on Rails 5.2. This is not obscure, it's "lo siguiente" :(. The answer is buried deep down in activerecord's sources: https://github.com/rails/rails/blob/662ba236d115d3e2152b04dcdefdc0ee6f1f6102/activerecord/lib/active_record/railties/databases.rake#L390

deivid-rodriguez · 2018-05-23T12:26:50Z

Nice! I've been rebasing this branch once in a while for a while, and it's been consistently green. Let's see if it stays like that.

mrcasals · 2018-05-23T13:56:37Z

@deivid-rodriguez should we merge then? 😄

deivid-rodriguez · 2018-05-23T13:58:37Z

Build passed, so unless you have feedback, yeah!

* Prevent Rails 5.2 deprecation warnings Like the following, or similar: ``` DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "name->'en' ASC". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql(). (called from index at /path/to/decidim-admin/app/controllers/decidim/admin/scopes_controller.rb:13) ``` * Only install decidim migrations This is necessary to ignore activestorage ones on Rails 5.2. This is not obscure, it's "lo siguiente" :(. The answer is buried deep down in activerecord's sources: https://github.com/rails/rails/blob/662ba236d115d3e2152b04dcdefdc0ee6f1f6102/activerecord/lib/active_record/railties/databases.rake#L390 * Tweak bootsnap to play nice with byebug * Bump Rails to 5.2 * Bootsnap is require in `config/boot.rb` of the default generated application, so we need to add it to the Gemfile. * Surveys were calling `save!` on `destroy!`'ed records, that's (understandably) no longer valid and was only working by chance. * A transaction block inside `Decidim.traceable` was no longer returning its last statement, so I needed to add a explicit return. I also removed a nested transaction block that seemed unnecessary. * Upgraded papertrail and fixed a deprecation warning about `whodunnit`. * Oauth's request env no longer has indifferent access. Apparently. * Try fix hang by not mixin ruby & rails autoloading * Try fix flaky in system UI

…3438) * take into account when space is private and transparent * Initial Commit * Show next upcoming meeting in assembly card (#3435) * Show next upcoming meeting in assembly card * Lint file * New Crowdin translations (#3432) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Catalan) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Catalan) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * Fix card image when missing (#3439) * Fix `Resourceable` concern to only find linked resources from published components (#3433) * Fix the related proposals shown on proposal show when component is unpublished (#3430) * fix the related proposals showed on proposal show when the component are unpublished * update gemfile lock app design * fix gemifile lock generators * add changelog line and apply requested changes * update changelog * Make `sibling_scope` only return resources from published components * Fix changelog * Remove N+1 * Improve code readability * Use array so that query doesn't fail * Don't seed with random scopes if the existing organization already have. (#3437) * Refactor global resource manifests (#3416) * Make ResourceManifests global * Make Component manifest not required for resources Some resource might not have a component (those froma participatory space, for example). * Set a name for a resource manifest * Fix all registered resources * Update Changelog * Fix code * Update docs and tests * Fix how to find the resource manifests * Remove outdated test * Fix `sibling_scope` fetching * Improve specs * Automatically set the ComponentManifest for the resources * Lint file * New Crowdin translations (#3440) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Catalan) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Catalan) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * Minute management interface (#3377) * meetings home * Collaborative editor * minutes edition * fix erblint * fix spanglish * Replace `high_voltage` with a custom code (#3441) * Replace `high_voltage` with a custom code * Fix locales * Normalize locale files * Remove old class * Make method public * Add user profile card (#3444) * Register users as a resource * Add user profile card * Manually specify the author card * Add missing locales for another_dummy_authorization_handler (#3447) * Add missing email format validations (#3446) * add email format validation to managed user promotion * add email format validation to meeting user invitation * Include datepicker locales in front pages too. (#3448) * [FIX] Consultations question component html error (#3450) * New user profile (#3415) * Fix user cell * Update user profile with new design * Update CHANGELOG * Add project card (#3454) * Add project card * Normalize locale files * [FIX] Added remove_introductory_image to Consultations form & command (#3455) * Rename migrations to avoid duplicated names (#3452) * Remove text (#3461) * Fix comments on development (#3459) * Set default `totalCommentsCount` value * Use lambdas on interfaces lists * Move to `ts-loader` * Update comments bundle * Fix lint * Run `erblint` on cells views (#3462) * [FIX] Use translations for hardcoded text. (#3464) * [FIX] Use translations for hardcoded text. * Add changelog entry. * [FIX] Fixes artificial margin between proposal "header" and list of endorsements. (#3465) * Add margin to .data-picker (#3463) * Added margin to .data-picker * fix variable, lint scss * Add Stylelinter to development_guide.md (#3472) * Add initiatives card (#3475) * Add initiative card * Improve footer * Lint files * Fix i18n specs * Fix authors list * Remove extra character * Extract ProgressBarCell from proposals * Add progress bar to initiatives cell * Replace "vote" with "sign"/"signature" on initiatives * Replace "adhesions" with "signatures" * Lint erb files * Lint cells files * Remove unused file * Normalize locales file * Lint more files * Fix specs * Update Facebook docs with an example URL (#3474) * Add label identifier to `card_m` (#3468) * Add label identifier to card_m * fix stylelint offenses * removed offending whitespace (stylelint) * fix .card_label status scope * Use `CollapsibleListCell` for proposal endorsements list (#3478) * Upgrade Rails to 5.2 (#3225) * Prevent Rails 5.2 deprecation warnings Like the following, or similar: ``` DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "name->'en' ASC". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql(). (called from index at /path/to/decidim-admin/app/controllers/decidim/admin/scopes_controller.rb:13) ``` * Only install decidim migrations This is necessary to ignore activestorage ones on Rails 5.2. This is not obscure, it's "lo siguiente" :(. The answer is buried deep down in activerecord's sources: https://github.com/rails/rails/blob/662ba236d115d3e2152b04dcdefdc0ee6f1f6102/activerecord/lib/active_record/railties/databases.rake#L390 * Tweak bootsnap to play nice with byebug * Bump Rails to 5.2 * Bootsnap is require in `config/boot.rb` of the default generated application, so we need to add it to the Gemfile. * Surveys were calling `save!` on `destroy!`'ed records, that's (understandably) no longer valid and was only working by chance. * A transaction block inside `Decidim.traceable` was no longer returning its last statement, so I needed to add a explicit return. I also removed a nested transaction block that seemed unnecessary. * Upgraded papertrail and fixed a deprecation warning about `whodunnit`. * Oauth's request env no longer has indifferent access. Apparently. * Try fix hang by not mixin ruby & rails autoloading * Try fix flaky in system UI * Add new translations (#3460) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Catalan) * New translations en.yml (Portuguese) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Spanish) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Spanish) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Galician) * New translations en.yml (Spanish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Spanish) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Italian) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Portuguese) * Update comments bundle * Unbundled consent on user registration (#3483) * Unbundled consent on user registration * [FEAT] Added RSpec tests for unbundled consent in Registration * minor fixes * Add CHANGELOG entry * fix codeclimate * Add more cards (#3487) * Add consultation card * Normalize locales files * Lint file * Add blog post card * Add changelog entry * Remove impossible condition * add changelog and specs * Newsletter checkbox unchecked by default (#3488) * [FEAT] Registration newsletter checkbox unchecked by default * [FEAT] Added Modal to show message and action to user. Tests updated * [FIX] Corrections to pass tests * add method can participate to participable concern

ghost assigned deivid-rodriguez Apr 15, 2018

ghost added the status: WIP label Apr 15, 2018

deivid-rodriguez force-pushed the rails_5.2 branch from 20d67bc to 8695ac6 Compare April 15, 2018 18:04

deivid-rodriguez mentioned this pull request Apr 15, 2018

Allow impersonating regular users + big refactoring of impersonations #3226

Merged

1 task

mrcasals reviewed Apr 16, 2018

View reviewed changes

josepjaume added this to the Release v.0.12.0 milestone Apr 16, 2018

josepjaume added the status: ❌ blocked label Apr 16, 2018

josepjaume previously approved these changes Apr 16, 2018

View reviewed changes

This was referenced Apr 16, 2018

Ci speed up #3231

Merged

Upgrade capybara to 3.0 #3232

Closed

deivid-rodriguez changed the title ~~Rails 5.2 + Capybara 3.0 + CI speed up~~ Uprade Rails to 5.2 Apr 16, 2018

deivid-rodriguez changed the title ~~Uprade Rails to 5.2~~ Upgrade Rails to 5.2 + Capybara 3.0 Apr 16, 2018

deivid-rodriguez dismissed josepjaume’s stale review via 7b19299 April 16, 2018 12:02

deivid-rodriguez force-pushed the rails_5.2 branch 2 times, most recently from 7b19299 to 2556b77 Compare April 16, 2018 16:41

deivid-rodriguez removed the status: WIP label Apr 17, 2018

deivid-rodriguez force-pushed the rails_5.2 branch from 2556b77 to e6b249a Compare April 24, 2018 17:30

ghost added the status: WIP label Apr 24, 2018

deivid-rodriguez force-pushed the rails_5.2 branch 5 times, most recently from 1e5d2f5 to 3ad2866 Compare May 1, 2018 16:59

deivid-rodriguez force-pushed the rails_5.2 branch 5 times, most recently from 2ee9d15 to 31a19e2 Compare May 4, 2018 17:50

deivid-rodriguez mentioned this pull request May 8, 2018

Upgrade to capybara 3 #3361

Merged

deivid-rodriguez force-pushed the rails_5.2 branch from 3e2fc17 to fc5c0a7 Compare May 9, 2018 18:58

deivid-rodriguez changed the title ~~Upgrade Rails to 5.2 + Capybara 3.0~~ Upgrade Rails to 5.2 May 9, 2018

deivid-rodriguez force-pushed the rails_5.2 branch from fc5c0a7 to a145d75 Compare May 22, 2018 19:57

mrcasals removed the status: ❌ blocked label May 23, 2018

mrcasals previously approved these changes May 23, 2018

View reviewed changes

deivid-rodriguez added 6 commits May 23, 2018 09:10

Tweak bootsnap to play nice with byebug

200aa3e

Try fix hang by not mixin ruby & rails autoloading

a4ad3b5

Try fix flaky in system UI

fa6a822

deivid-rodriguez dismissed mrcasals’s stale review via fa6a822 May 23, 2018 12:11

deivid-rodriguez force-pushed the rails_5.2 branch from a145d75 to fa6a822 Compare May 23, 2018 12:11

deivid-rodriguez added in-review and removed status: WIP labels May 23, 2018

mrcasals approved these changes May 23, 2018

View reviewed changes

mrcasals merged commit 20b5d2c into master May 23, 2018

mrcasals deleted the rails_5.2 branch May 23, 2018 14:07

oriolgual mentioned this pull request Nov 27, 2018

External test app generator not copying module's migrations #4572

Closed

Uh oh!

Conversation

deivid-rodriguez commented Apr 15, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

Uh oh!

mrcasals Apr 16, 2018

Choose a reason for hiding this comment

Uh oh!

josepjaume Apr 16, 2018

Choose a reason for hiding this comment

Uh oh!

oriolgual Apr 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

deivid-rodriguez Apr 16, 2018

Choose a reason for hiding this comment

Uh oh!

josepjaume left a comment

Choose a reason for hiding this comment

Uh oh!

deivid-rodriguez commented Apr 16, 2018

Uh oh!

mrcasals commented Apr 16, 2018

Uh oh!

mrcasals commented May 8, 2018

Uh oh!

deivid-rodriguez commented May 8, 2018

Uh oh!

mrcasals commented May 9, 2018

Uh oh!

mrcasals commented May 23, 2018

Uh oh!

deivid-rodriguez commented May 23, 2018

Uh oh!

mrcasals commented May 23, 2018

Uh oh!

deivid-rodriguez commented May 23, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

deivid-rodriguez commented Apr 15, 2018 •

edited

Loading

oriolgual Apr 16, 2018 •

edited

Loading