Non private users can participate to a private, transparent assembly by isaacmg410 · Pull Request #3438 · decidim/decidim

isaacmg410 · 2018-05-16T14:02:06Z

🎩 What? Why?

non private users, can participate to a private and transparent assembly should be able to see it but not to participate.

📌 Related Issues

Related to Private processes or assemblies #2282 Private processes or assemblies #2618
Fixes Non-member users can participate to a private, transparent assembly #3423

📋 Subtasks

Add CHANGELOG entry
Fix Proposals
Fix Projects
Add tests

📷 Screenshots (optional)

* Show next upcoming meeting in assembly card * Lint file

* New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Catalan) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Catalan) * New translations en.yml (Spanish) * New translations en.yml (Spanish)

…ed components (#3433) * Fix the related proposals shown on proposal show when component is unpublished (#3430) * fix the related proposals showed on proposal show when the component are unpublished * update gemfile lock app design * fix gemifile lock generators * add changelog line and apply requested changes * update changelog * Make `sibling_scope` only return resources from published components * Fix changelog * Remove N+1 * Improve code readability * Use array so that query doesn't fail

…ve. (#3437)

* Make ResourceManifests global * Make Component manifest not required for resources Some resource might not have a component (those froma participatory space, for example). * Set a name for a resource manifest * Fix all registered resources * Update Changelog * Fix code * Update docs and tests * Fix how to find the resource manifests * Remove outdated test * Fix `sibling_scope` fetching * Improve specs * Automatically set the ComponentManifest for the resources * Lint file

* New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Catalan) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Catalan) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish)

* meetings home * Collaborative editor * minutes edition * fix erblint * fix spanglish

* Replace `high_voltage` with a custom code * Fix locales * Normalize locale files * Remove old class * Make method public

* Register users as a resource * Add user profile card * Manually specify the author card

* add email format validation to managed user promotion * add email format validation to meeting user invitation

* Fix user cell * Update user profile with new design * Update CHANGELOG

* Add project card * Normalize locale files

…#3455)

* Set default `totalCommentsCount` value * Use lambdas on interfaces lists * Move to `ts-loader` * Update comments bundle * Fix lint

* [FIX] Use translations for hardcoded text. * Add changelog entry.

…ndorsements. (#3465)

* Added margin to .data-picker * fix variable, lint scss

* Add initiative card * Improve footer * Lint files * Fix i18n specs * Fix authors list * Remove extra character * Extract ProgressBarCell from proposals * Add progress bar to initiatives cell * Replace "vote" with "sign"/"signature" on initiatives * Replace "adhesions" with "signatures" * Lint erb files * Lint cells files * Remove unused file * Normalize locales file * Lint more files * Fix specs

* Add label identifier to card_m * fix stylelint offenses * removed offending whitespace (stylelint) * fix .card_label status scope

* Prevent Rails 5.2 deprecation warnings Like the following, or similar: ``` DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with non-attribute argument(s): "name->'en' ASC". Non-attribute arguments will be disallowed in Rails 6.0. This method should not be called with user-provided values, such as request parameters or model attributes. Known-safe values can be passed by wrapping them in Arel.sql(). (called from index at /path/to/decidim-admin/app/controllers/decidim/admin/scopes_controller.rb:13) ``` * Only install decidim migrations This is necessary to ignore activestorage ones on Rails 5.2. This is not obscure, it's "lo siguiente" :(. The answer is buried deep down in activerecord's sources: https://github.com/rails/rails/blob/662ba236d115d3e2152b04dcdefdc0ee6f1f6102/activerecord/lib/active_record/railties/databases.rake#L390 * Tweak bootsnap to play nice with byebug * Bump Rails to 5.2 * Bootsnap is require in `config/boot.rb` of the default generated application, so we need to add it to the Gemfile. * Surveys were calling `save!` on `destroy!`'ed records, that's (understandably) no longer valid and was only working by chance. * A transaction block inside `Decidim.traceable` was no longer returning its last statement, so I needed to add a explicit return. I also removed a nested transaction block that seemed unnecessary. * Upgraded papertrail and fixed a deprecation warning about `whodunnit`. * Oauth's request env no longer has indifferent access. Apparently. * Try fix hang by not mixin ruby & rails autoloading * Try fix flaky in system UI

* New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Catalan) * New translations en.yml (Portuguese) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Polish) * New translations en.yml (Catalan) * New translations en.yml (Swedish) * New translations en.yml (Spanish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Basque) * New translations en.yml (Dutch) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Spanish) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Spanish) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Galician) * New translations en.yml (Spanish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Spanish) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Italian) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Italian) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Dutch) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Finnish) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Portuguese) * Update comments bundle

* Unbundled consent on user registration * [FEAT] Added RSpec tests for unbundled consent in Registration * minor fixes * Add CHANGELOG entry

* Add consultation card * Normalize locales files * Lint file * Add blog post card * Add changelog entry * Remove impossible condition

* [FEAT] Registration newsletter checkbox unchecked by default * [FEAT] Added Modal to show message and action to user. Tests updated * [FIX] Corrections to pass tests

isaacmg410 · 2018-05-25T08:33:28Z

@decidim/lot-core ready to review and merge

mrcasals · 2018-05-25T10:13:40Z

decidim-consultations/app/models/decidim/consultation.rb

      end
    end
+
+    def can_participate?(_user)


Should we move this to the Decidim::Parrticipable concern as the default method? This way other participatory spaces can redefine it it they need to, but we ensure every participatory space responds to this method.

#### 🎩 What? Why? This PR fixes that as a normal user (no private user) I can comment on a private assembly where is available. Meetigns, Proposals, etc. #### 📌 Related Issues - Related to #2618 #3438 - Fixes #4869 #### 📋 Subtasks - [x] Add `CHANGELOG` entry - [x] Add tests ### 📷 Screenshots (optional) ![Description](URL)

take into account when space is private and transparent

57d8208

ghost assigned isaacmg410 May 16, 2018

ghost added the status: WIP label May 16, 2018

isaacmg410 removed the status: WIP label May 25, 2018

ghost added the status: WIP label May 25, 2018

Isaac Massot and others added 25 commits May 25, 2018 09:37

Initial Commit

bec9703

Show next upcoming meeting in assembly card (#3435)

df5f9cf

* Show next upcoming meeting in assembly card * Lint file

Fix card image when missing (#3439)

d7fb4c3

Don't seed with random scopes if the existing organization already ha…

938dd5a

…ve. (#3437)

Minute management interface (#3377)

25c497e

* meetings home * Collaborative editor * minutes edition * fix erblint * fix spanglish

Replace high_voltage with a custom code (#3441)

023ae04

* Replace `high_voltage` with a custom code * Fix locales * Normalize locale files * Remove old class * Make method public

Add user profile card (#3444)

5682eaf

* Register users as a resource * Add user profile card * Manually specify the author card

Add missing locales for another_dummy_authorization_handler (#3447)

f205217

Add missing email format validations (#3446)

78a7c0f

* add email format validation to managed user promotion * add email format validation to meeting user invitation

Include datepicker locales in front pages too. (#3448)

666acdd

[FIX] Consultations question component html error (#3450)

13c7b04

New user profile (#3415)

41a8f82

* Fix user cell * Update user profile with new design * Update CHANGELOG

Add project card (#3454)

9b738e9

* Add project card * Normalize locale files

[FIX] Added remove_introductory_image to Consultations form & command (…

b886192

…#3455)

Rename migrations to avoid duplicated names (#3452)

6b7c6ba

Remove text (#3461)

2bdfffe

Fix comments on development (#3459)

8f28a33

* Set default `totalCommentsCount` value * Use lambdas on interfaces lists * Move to `ts-loader` * Update comments bundle * Fix lint

Run erblint on cells views (#3462)

6e282e3

[FIX] Use translations for hardcoded text. (#3464)

64e4db7

* [FIX] Use translations for hardcoded text. * Add changelog entry.

[FIX] Fixes artificial margin between proposal "header" and list of e…

064334a

…ndorsements. (#3465)

Add margin to .data-picker (#3463)

093513e

* Added margin to .data-picker * fix variable, lint scss

agustibr and others added 12 commits May 25, 2018 09:37

Add Stylelinter to development_guide.md (#3472)

3c3e8b1

Update Facebook docs with an example URL (#3474)

69dffed

Add label identifier to card_m (#3468)

7b21f26

* Add label identifier to card_m * fix stylelint offenses * removed offending whitespace (stylelint) * fix .card_label status scope

Use CollapsibleListCell for proposal endorsements list (#3478)

55b877d

Unbundled consent on user registration (#3483)

dbd4f4a

* Unbundled consent on user registration * [FEAT] Added RSpec tests for unbundled consent in Registration * minor fixes * Add CHANGELOG entry

fix codeclimate

6863eb4

add changelog and specs

57759f3

Add more cards (#3487)

4a0b27c

* Add consultation card * Normalize locales files * Lint file * Add blog post card * Add changelog entry * Remove impossible condition

Newsletter checkbox unchecked by default (#3488)

992fde4

* [FEAT] Registration newsletter checkbox unchecked by default * [FEAT] Added Modal to show message and action to user. Tests updated * [FIX] Corrections to pass tests

isaacmg410 force-pushed the bugfix_space_private_transparent_components branch from 82a7238 to 992fde4 Compare May 25, 2018 07:38

Merge branch 'master' into bugfix_space_private_transparent_components

144ecfe

isaacmg410 added in-review and removed status: WIP labels May 25, 2018

mrcasals reviewed May 25, 2018

View reviewed changes

Merge branch 'master' into bugfix_space_private_transparent_components

d413057

ghost added the status: WIP label May 25, 2018

add method can participate to participable concern

191d68d

isaacmg410 removed the status: WIP label May 25, 2018

mrcasals approved these changes May 25, 2018

View reviewed changes

mrcasals merged commit a96fe43 into master May 25, 2018

mrcasals deleted the bugfix_space_private_transparent_components branch May 25, 2018 14:01

isaacmg410 mentioned this pull request Sep 13, 2018

fix create debates as a normal user in a private space #4108

Merged

3 tasks

leio10 mentioned this pull request Feb 21, 2019

Refactor private space checks #4889

Merged

1 task

isaacmg410 mentioned this pull request Feb 22, 2019

[WIP] fix user can comment in private assembly even if user don't have permissions #4893

Closed

5 tasks

isaacmg410 mentioned this pull request Mar 4, 2019

Fix users can comment into private assembly #4924

Merged

2 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Non private users can participate to a private, transparent assembly#3438

Non private users can participate to a private, transparent assembly#3438
mrcasals merged 41 commits intomasterfrom
bugfix_space_private_transparent_components

isaacmg410 commented May 16, 2018 •

edited

Loading

Uh oh!

isaacmg410 commented May 25, 2018

Uh oh!

mrcasals May 25, 2018 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Conversation

isaacmg410 commented May 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

Uh oh!

isaacmg410 commented May 25, 2018

Uh oh!

mrcasals May 25, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

isaacmg410 commented May 16, 2018 •

edited

Loading

mrcasals May 25, 2018 •

edited

Loading