Conversation
Because: * We can configure quietness. * It's Ctrl-C friendly. Since we're configuring puma directly, add a explicit dev dependency on it.
oriolgual
approved these changes
May 9, 2018
isaacmg410
pushed a commit
to CodiTramuntana/decidim
that referenced
this pull request
May 25, 2018
* Bump capybara version to 3.0.3 * Use capybara's default server Because: * We can configure quietness. * It's Ctrl-C friendly. Since we're configuring puma directly, add a explicit dev dependency on it. * Add a rake task to bundle all gemfiles at once * Store logs as artifacts on circle CI failures * Add "HTML screenshots" to test failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This is the alternative I mentioned in #3225 (comment), so that we can upgrade capybara without having to attempt a full rails upgrade.
📌 Related Issues
📋 Subtasks
None.
📷 Screenshots (optional)
None.