Conversation
Contributor
Author
|
@decidim/lot-core does this PR require a CHANGELOG annotation? |
Contributor
|
@tramuntanal I think it'd be good to have a changelog entry for this, yes. |
Contributor
|
Also, current code breaks the test app, so you'll need to check if the current user can enable extensions and do it. If they can't enable them, then you'll have to raise. |
Codecov Report
@@ Coverage Diff @@
## master #3053 +/- ##
==========================================
- Coverage 98.62% 98.45% -0.18%
==========================================
Files 1699 1553 -146
Lines 40602 36721 -3881
==========================================
- Hits 40042 36152 -3890
- Misses 560 569 +9 |
| class EnablePgExtensions < ActiveRecord::Migration[5.1] | ||
| def change | ||
| enable_extension "pg_trgm" | ||
| return unless extension_enabled?("pg_trgm") |
Contributor
There was a problem hiding this comment.
I think you mean return if?
Contributor
Author
There was a problem hiding this comment.
Yeah of course!
Contributor
|
@deivid-rodriguez does this look good to you? It certainly does to me, but I'd like to get another review before merging 😄 |
deivid-rodriguez
approved these changes
Mar 21, 2018
Contributor
deivid-rodriguez
left a comment
There was a problem hiding this comment.
Yes, looks good!
mrcasals
approved these changes
Mar 21, 2018
rbngzlv
added a commit
that referenced
this pull request
Mar 21, 2018
* master: [RFC] Use cells for meeting m cards (#3022) Do not force Postgresql user to be admin when enabling trigram extension (#3053) Make organization reference_prefix required (#3056) admin can duplicate/copy meetings (#3051) Fix question form errors not being displayed (#3046) Erb whitespace cutting (#3047) Show debates statistics on space show and homepage (#3016) Fix broken translated field after form errors (#3026) Move decidim executable to "exe" folder (#3028) Friendlier buttons (#3027) Feedback needed after Endorsing when user has no user_groups (#2998) Fix seeding error on generator specs (#3021) fix spelling error in threshold (#3019) Migration plus seeds (#2933)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Resolves what is commented in issue #3045 .
📌 Related Issues
📋 Subtasks
CHANGELOGentry