Show debates statistics on space show and homepage#3016
Merged
Conversation
Contributor
Author
|
@decidim/product thoughts on this? Is this acceptable? Should I move debates to a lower priority rank in the homepage? |
oriolgual
approved these changes
Mar 16, 2018
Codecov Report
@@ Coverage Diff @@
## master #3016 +/- ##
==========================================
+ Coverage 98.67% 98.67% +<.01%
==========================================
Files 1698 1698
Lines 40500 40502 +2
==========================================
+ Hits 39964 39966 +2
Misses 536 536 |
Contributor
Author
|
Merging this, if @decidim/product thinks we need to change something it can be done in another PR |
rbngzlv
added a commit
that referenced
this pull request
Mar 21, 2018
* master: [RFC] Use cells for meeting m cards (#3022) Do not force Postgresql user to be admin when enabling trigram extension (#3053) Make organization reference_prefix required (#3056) admin can duplicate/copy meetings (#3051) Fix question form errors not being displayed (#3046) Erb whitespace cutting (#3047) Show debates statistics on space show and homepage (#3016) Fix broken translated field after form errors (#3026) Move decidim executable to "exe" folder (#3028) Friendlier buttons (#3027) Feedback needed after Endorsing when user has no user_groups (#2998) Fix seeding error on generator specs (#3021) fix spelling error in threshold (#3019) Migration plus seeds (#2933)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
I noticed debates were not exporting their statistics. This PR adds statistics both in the homepage and in the participatory space page. The only thing we can discuss here is wether we want to show debates as a priority statistics, or as a secondary one (this only affects the homepage). In the screenshot, priority stats would be "Participants", "assemblies", etc, while secondary would be "Meetings"
📌 Related Issues
None
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
Homepage:
Participatory space page:
