Friendlier buttons for dynamic fields#3027
Merged
josepjaume merged 1 commit intomasterfrom Mar 19, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3027 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 1699 1699
Lines 40568 40568
=======================================
Hits 40032 40032
Misses 536 536 |
Contributor
|
It makes waaay more sense! 👏 |
josepjaume
approved these changes
Mar 19, 2018
rbngzlv
added a commit
that referenced
this pull request
Mar 21, 2018
* master: [RFC] Use cells for meeting m cards (#3022) Do not force Postgresql user to be admin when enabling trigram extension (#3053) Make organization reference_prefix required (#3056) admin can duplicate/copy meetings (#3051) Fix question form errors not being displayed (#3046) Erb whitespace cutting (#3047) Show debates statistics on space show and homepage (#3016) Fix broken translated field after form errors (#3026) Move decidim executable to "exe" folder (#3028) Friendlier buttons (#3027) Feedback needed after Endorsing when user has no user_groups (#2998) Fix seeding error on generator specs (#3021) fix spelling error in threshold (#3019) Migration plus seeds (#2933)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While working on surveys I noticed something that it strikes as a bit weird to me. The button to add dynamic fields to a survey is placed on top of all the currently existing dynamic fields, not at the bottom. So if you're adding fields one by one, you have to constantly go back to the top when you want to create more fields.
I guess if you know the exact number of dynamic fields to be added upfront (say 9), you can "fix" the problem by clicking on the button 9 times and forget about it. But I don't think that's the way usually people interact with these forms.
I thought of opening an issue to discuss this (in case it is intentional), but it was easier to open a PR to better explain it. Tagging it as discussion though :)
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)
Before
Before with workaround
After