Skip to content

Backport 'Add authorization to GraphQL ' to v0.28#13759

Merged
alecslupu merged 5 commits intorelease/0.28-stablefrom
backport/0.28/add-authorization-to-graphql-13511
Dec 13, 2024
Merged

Backport 'Add authorization to GraphQL ' to v0.28#13759
alecslupu merged 5 commits intorelease/0.28-stablefrom
backport/0.28/add-authorization-to-graphql-13511

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

🎩 What? Why?

Backport #13511 to v0.28

♥️ Thank you!

* Temp commit

* Adding authorization layer

* Add more permission checks

* Running linters

* Add Commentable tests

* Fix spec

* Do not show the moderated or deleted comments

* Add conditions for comments, users and user groups

* Fixing specs

* Fix latest round of specs

* Fix organization spec

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Add Praticipatory space is private but transparent

* Add Praticipatory space is private but transparent for accountability

* Add Praticipatory space is private but transparent for debates

* Add Praticipatory space is private but transparent for meetings

* Add Praticipatory space is private but transparent for forms

* Add Praticipatory space is private but transparent for proposals

* Add Praticipatory space is private but transparent for sortitions

* Linting

* Fix visibility on assemblies

* Refactor

* Fix specs

* Fix specs

* Fix specs, refactor the name of specs

* Additional GraphQL fixes (#13602)

* Additional GraphQL fixes

* More fixes

* Fix spec

* Add specs

* Fix specs

* Fix permission

* Apply review recommendations

* Apply suggestions from code review

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Apply review recommendations

* Refactor specs

* Apply review recommendations

* Running linters

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

* Refactor context to avoid codeclimate

* running lint

* Fix specs

---------

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
@alecslupu alecslupu added backport Pull Requests that are a backport for a fixed bug criticality: high type: fix PRs that implement a fix for a bug labels Dec 11, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 11, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 11, 2024
github-actions[bot]
github-actions bot previously approved these changes Dec 11, 2024
@alecslupu alecslupu added this to the 0.28.5 milestone Dec 12, 2024
@alecslupu alecslupu requested a review from greenwoodt December 12, 2024 07:42
Copy link
Copy Markdown
Member

@greenwoodt greenwoodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, lets go for the merge on v0.28!

@alecslupu alecslupu merged commit d6e28bf into release/0.28-stable Dec 13, 2024
@alecslupu alecslupu deleted the backport/0.28/add-authorization-to-graphql-13511 branch December 13, 2024 13:31
ahukkanen added a commit to City-of-Turku/decidim-module-apiext that referenced this pull request Sep 10, 2025
Apply the fix from the following core PR:
decidim/decidim#15170

Comments fetching was broken since 0.28.5 due to this breaking
change:
decidim/decidim#13759
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Pull Requests that are a backport for a fixed bug criticality: high type: fix PRs that implement a fix for a bug

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants