Add authorization to GraphQL #13511
Merged
andreslucena merged 39 commits intodevelopfrom Dec 11, 2024
Merged
Conversation
andreslucena
requested changes
Oct 17, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
As I mentioned, I think this is the correct approach, as it's what I would expect from this fix.
I have lots of comments but you'll see that there are only like 4 distinct, so it should not be difficult to implement them
* Additional GraphQL fixes * More fixes * Fix spec * Add specs * Fix specs * Fix permission * Apply review recommendations * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply review recommendations * Refactor specs * Apply review recommendations * Running linters --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
andreslucena
approved these changes
Dec 11, 2024
Member
andreslucena
left a comment
There was a problem hiding this comment.
I gave it a last spin locally and could not come up with other use cases or examples.
The only thing that I had doubts was regarding #13122, but as far as I understand that's covered by the unpublished examples. If there's something that I'm missing please let me know (and we can work it out in another PR if so)
This was referenced Dec 11, 2024
antopalidi
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Temp commit * Adding authorization layer * Add more permission checks * Running linters * Add Commentable tests * Fix spec * Do not show the moderated or deleted comments * Add conditions for comments, users and user groups * Fixing specs * Fix latest round of specs * Fix organization spec * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add Praticipatory space is private but transparent * Add Praticipatory space is private but transparent for accountability * Add Praticipatory space is private but transparent for debates * Add Praticipatory space is private but transparent for meetings * Add Praticipatory space is private but transparent for forms * Add Praticipatory space is private but transparent for proposals * Add Praticipatory space is private but transparent for sortitions * Linting * Fix visibility on assemblies * Refactor * Fix specs * Fix specs * Fix specs, refactor the name of specs * Additional GraphQL fixes (#13602) * Additional GraphQL fixes * More fixes * Fix spec * Add specs * Fix specs * Fix permission * Apply review recommendations * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply review recommendations * Refactor specs * Apply review recommendations * Running linters --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Refactor context to avoid codeclimate * running lint * Fix specs --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
We are adding basic authorization to GraphQL, so that we avoid displaying unpublished entries.
📌 Related Issues
Link your PR to an issue
Testing
Browse the API, and see that you can request or view deleted or moderated content.