Additional GraphQL fixes by alecslupu · Pull Request #13602 · decidim/decidim

alecslupu · 2024-11-04T21:19:57Z

🎩 What? Why?

This PR adds some additional GraphQL imrovements.

Decouples Decidim::ParticipatoryProcessType to the engine instead of Core
Fixes a bug when single private spaces could not be found by admin
Fixes a bug when unpublished components could not be found via api by admin

📌 Related Issues

Link your PR to an issue

Related to Add authorization to GraphQL #13511

Testing

Authentitate to admin
Unpublish a component from a participatory space
As admin interogate API to fetch the components
See there is an error
Make the space private, see the admin cannot interogate via API
Apply patch & restart server
See space is now visible
See the component is visible
In incognito, as not logged in user, repeat 3, 4
See the space is not visible ( returns null )
Make the space public, and see in api it cannot be viewed by anonymous user

{
  participatoryProcess(id: 2){
    id
    components {
      id
      name {
        translation(locale: "en")
      }
    }
  }
}

📷 Screenshots

Please add screenshots of the changes you are proposing

♥️ Thank you!

…nal-graphql-fixes

…o fix/additional-graphql-fixes

decidim-budgets/spec/types/integration_schema_spec.rb

andreslucena · 2024-11-08T10:32:18Z

Is this ready for a review @alecslupu ?

andreslucena

As we're talking about the visibility of the resources, I prefer to be extra explicit in the behavior, specially as it's easy to make mistakes when copying and pasting the different examples.

I made a quick suggestion but it should be done in the rest of the examples (or an alternative solution/wording/etc that tackles this problem)

I also prefer using the term "visitor" instead of "anonymous", as that's what we use in the User Stories as this type of user (and it's better for everyone to speak the same language in Product/Development/Documentation/etc)

decidim-api/lib/decidim/api/test/component_context.rb

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

…idim into fix/additional-graphql-fixes

…nal-graphql-fixes

.github/workflows/test_app.yml

andreslucena

As this will be merged in an intermediary PR, this LGTM for now, as I want to test the full behavior in that PR

* Temp commit * Adding authorization layer * Add more permission checks * Running linters * Add Commentable tests * Fix spec * Do not show the moderated or deleted comments * Add conditions for comments, users and user groups * Fixing specs * Fix latest round of specs * Fix organization spec * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add Praticipatory space is private but transparent * Add Praticipatory space is private but transparent for accountability * Add Praticipatory space is private but transparent for debates * Add Praticipatory space is private but transparent for meetings * Add Praticipatory space is private but transparent for forms * Add Praticipatory space is private but transparent for proposals * Add Praticipatory space is private but transparent for sortitions * Linting * Fix visibility on assemblies * Refactor * Fix specs * Fix specs * Fix specs, refactor the name of specs * Additional GraphQL fixes (#13602) * Additional GraphQL fixes * More fixes * Fix spec * Add specs * Fix specs * Fix permission * Apply review recommendations * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply review recommendations * Refactor specs * Apply review recommendations * Running linters --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Refactor context to avoid codeclimate * running lint * Fix specs --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> fixes (#13602)

* Temp commit * Adding authorization layer * Add more permission checks * Running linters * Add Commentable tests * Fix spec * Do not show the moderated or deleted comments * Add conditions for comments, users and user groups * Fixing specs * Fix latest round of specs * Fix organization spec * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Add Praticipatory space is private but transparent * Add Praticipatory space is private but transparent for accountability * Add Praticipatory space is private but transparent for debates * Add Praticipatory space is private but transparent for meetings * Add Praticipatory space is private but transparent for forms * Add Praticipatory space is private but transparent for proposals * Add Praticipatory space is private but transparent for sortitions * Linting * Fix visibility on assemblies * Refactor * Fix specs * Fix specs * Fix specs, refactor the name of specs * Additional GraphQL fixes (#13602) * Additional GraphQL fixes * More fixes * Fix spec * Add specs * Fix specs * Fix permission * Apply review recommendations * Apply suggestions from code review Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Apply review recommendations * Refactor specs * Apply review recommendations * Running linters --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Refactor context to avoid codeclimate * running lint * Fix specs --------- Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Additional GraphQL fixes

32ebdf3

alecslupu added graphql-api Affects the GraphQL API module: api type: fix PRs that implement a fix for a bug and removed module: api labels Nov 4, 2024

github-actions bot approved these changes Nov 4, 2024

View reviewed changes

alecslupu added module: proposals module: core module: meetings module: accountability module: blogs module: participatory processes labels Nov 4, 2024

More fixes

78bd2c6

alecslupu force-pushed the fix/additional-graphql-fixes branch from 2dbceea to 78bd2c6 Compare November 4, 2024 21:38

alecslupu added 5 commits November 5, 2024 07:26

Fix spec

937f5d5

Merge branch 'develop' of github.com:decidim/decidim into fix/additio…

1613fa5

…nal-graphql-fixes

Merge branch 'fix/fix-graphql-type' into fix/additional-graphql-fixes

417bde0

Add specs

475028c

Merge branch 'fix/fix-graphql-type' of github.com:decidim/decidim int…

819de2c

…o fix/additional-graphql-fixes

alecslupu commented Nov 6, 2024

View reviewed changes

decidim-budgets/spec/types/integration_schema_spec.rb Show resolved Hide resolved

alecslupu added 2 commits November 6, 2024 20:45

Fix specs

6dbec47

Fix permission

e56b017

alecslupu assigned andreslucena Nov 7, 2024

andreslucena reviewed Nov 8, 2024

View reviewed changes

decidim-api/lib/decidim/api/test/component_context.rb Outdated Show resolved Hide resolved

decidim-api/lib/decidim/api/test/component_context.rb Outdated Show resolved Hide resolved

decidim-api/lib/decidim/api/test/component_context.rb Outdated Show resolved Hide resolved

Apply review recommendations

89fee85

andreslucena reviewed Nov 11, 2024

View reviewed changes

alecslupu and others added 3 commits November 11, 2024 17:05

Apply suggestions from code review

a4af68d

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>

Apply review recommendations

bd1c077

Merge branch 'fix/additional-graphql-fixes' of github.com:decidim/dec…

4455fea

…idim into fix/additional-graphql-fixes

alecslupu added 4 commits November 11, 2024 20:59

Refactor specs

62c2429

Apply review recommendations

d1a5fec

Running linters

0a36a00

Merge branch 'develop' of github.com:decidim/decidim into fix/additio…

724cb9d

…nal-graphql-fixes

andreslucena reviewed Nov 18, 2024

View reviewed changes

.github/workflows/test_app.yml Show resolved Hide resolved

Merge branch 'fix/fix-graphql-type' into fix/additional-graphql-fixes

0a29c70

andreslucena approved these changes Nov 19, 2024

View reviewed changes

andreslucena merged commit 0a958ff into fix/fix-graphql-type Nov 19, 2024

andreslucena deleted the fix/additional-graphql-fixes branch November 19, 2024 08:19

alecslupu added the no-backport Pull Requests that should not be backported label Nov 20, 2024

alecslupu added a commit that referenced this pull request Dec 13, 2024

Backport 'Add authorization to GraphQL ' to v0.29 (#13758)

674556a

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> fixes (#13602)

alecslupu added a commit that referenced this pull request Dec 13, 2024

Backport 'Add authorization to GraphQL ' to v0.28 (#13759)

d6e28bf

Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> fixes (#13602)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Additional GraphQL fixes#13602

Additional GraphQL fixes#13602
andreslucena merged 18 commits intofix/fix-graphql-typefrom
fix/additional-graphql-fixes

alecslupu commented Nov 4, 2024

Uh oh!

Uh oh!

andreslucena commented Nov 8, 2024

Uh oh!

andreslucena left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andreslucena left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

alecslupu commented Nov 4, 2024

🎩 What? Why?

📌 Related Issues

Testing

📷 Screenshots

Uh oh!

Uh oh!

andreslucena commented Nov 8, 2024

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

andreslucena left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants