Skip to content

Clean-up initiatives signature URLs and methods#11545

Merged
andreslucena merged 1 commit intodevelopfrom
refactor/initiative_signatures_routing
Aug 29, 2023
Merged

Clean-up initiatives signature URLs and methods#11545
andreslucena merged 1 commit intodevelopfrom
refactor/initiative_signatures_routing

Conversation

@alecslupu
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu commented Aug 29, 2023

🎩 What? Why?

While reviewing #10731, @andreslucena requested some optional changes in the following comment:
#10731 (review)

📌 Related Issues

Link your PR to an issue

Testing

  1. Make sure the pipeline is green.
  2. Find an initiative that needs signing
  3. Configure the signing parameters (personal data collection, sms validation )
  4. Attempt to sign it
  5. See everything works as expected

♥️ Thank you!

Base automatically changed from refactor/initiative_signatures to develop August 29, 2023 11:34
@alecslupu alecslupu force-pushed the refactor/initiative_signatures_routing branch from 6a86b27 to 63c6138 Compare August 29, 2023 11:36
@alecslupu alecslupu added module: initiatives type: change PRs that implement a change for an existing feature labels Aug 29, 2023
@alecslupu alecslupu added this to the 0.28.0 milestone Aug 29, 2023
@alecslupu alecslupu requested a review from andreslucena August 29, 2023 11:38
@alecslupu alecslupu marked this pull request as ready for review August 29, 2023 11:57
@andreslucena andreslucena changed the title Refactor intiative signature urls Clean-up intiatives signature URLs and methods Aug 29, 2023
@andreslucena andreslucena changed the title Clean-up intiatives signature URLs and methods Clean-up initiatives signature URLs and methods Aug 29, 2023
Copy link
Copy Markdown
Member

@andreslucena andreslucena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽 Just what I had in mind, thanks!

@andreslucena andreslucena merged commit 40aab10 into develop Aug 29, 2023
@andreslucena andreslucena deleted the refactor/initiative_signatures_routing branch August 29, 2023 12:55
entantoencuanto added a commit that referenced this pull request Aug 30, 2023
* develop:
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  Fix 'download your data' when there are comments on budgets (#11531)
entantoencuanto added a commit that referenced this pull request Sep 8, 2023
…gn-staging

* fix/activities-block-follow-button: (27 commits)
  Add tests to follow button in processes and assemblies landing page
  Add follow button to participatory spaces last activities content block
  Remove duplication from participatory spaces publications controllers (#11549)
  Fix the a11y tool icons with redesign (#11175)
  Remove duplication from amendments events specs (#11553)
  Remove duplication from elections' user roles forms (#11548)
  Update Node.js from v16.13.0 to v18.17.1 (#11564)
  Remove duplication from stats presenters (#11551)
  Fix Bootsnap configuration (#11483)
  Remove duplication for add questions specs examples (#11559)
  Remove duplication from invites queries (#11552)
  Fix typos and copy-paste errors from comments and examples (#11536)
  Fix conference venues meetings visibility (#11542)
  Add recognition to BrowserStack in the README (#11546)
  Remove unused view hook for `:upcoming_meeting_for_card` (#11543)
  Remove unused dependency: `wicked` (#11150)
  Clean-up initiatives signature URLs and methods (#11545)
  Refactor initiative signing wizard (#10731)
  Fix Permissions screen on budgets throw errors (#11532)
  Redesign: read more literal (#11516)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: initiatives type: change PRs that implement a change for an existing feature

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants