Fix the a11y tool icons with redesign#11175
Merged
andreslucena merged 2 commits intodevelopfrom Sep 7, 2023
Merged
Conversation
andreslucena
approved these changes
Sep 7, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
Great!
For the green check I had to remove the breadcrumb as we currently have a violation there.
Thanks for the PR!
Member
|
I'm ignoring the pending check from codeclimate as it hanged |
entantoencuanto
added a commit
that referenced
this pull request
Sep 8, 2023
…gn-staging * fix/activities-block-follow-button: (27 commits) Add tests to follow button in processes and assemblies landing page Add follow button to participatory spaces last activities content block Remove duplication from participatory spaces publications controllers (#11549) Fix the a11y tool icons with redesign (#11175) Remove duplication from amendments events specs (#11553) Remove duplication from elections' user roles forms (#11548) Update Node.js from v16.13.0 to v18.17.1 (#11564) Remove duplication from stats presenters (#11551) Fix Bootsnap configuration (#11483) Remove duplication for add questions specs examples (#11559) Remove duplication from invites queries (#11552) Fix typos and copy-paste errors from comments and examples (#11536) Fix conference venues meetings visibility (#11542) Add recognition to BrowserStack in the README (#11546) Remove unused view hook for `:upcoming_meeting_for_card` (#11543) Remove unused dependency: `wicked` (#11150) Clean-up initiatives signature URLs and methods (#11545) Refactor initiative signing wizard (#10731) Fix Permissions screen on budgets throw errors (#11532) Redesign: read more literal (#11516) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Now that the redesign is merged to develop, we can switch the a11y tool to use the redesigned icons for it to display correctly under redesign.
After this, the icons will be displayed correctly with the tool. There is some further work to do to fix it completely, e.g. displaying the clickable sections with link colors, etc. i.e. to apply the correct Tailwind classes to the tool.
📌 Related Issues
Testing
Check the top left corner of the development app, you should see the a11y tool icons displayed correctly.
Open the a11y sidebar after which you should also see the violation icons on the page where violations are indicated.