Remove unused view hook for :upcoming_meeting_for_card#11543
Merged
andreslucena merged 1 commit intodevelopfrom Aug 30, 2023
Merged
Remove unused view hook for :upcoming_meeting_for_card#11543andreslucena merged 1 commit intodevelopfrom
:upcoming_meeting_for_card#11543andreslucena merged 1 commit intodevelopfrom
Conversation
andreslucena
approved these changes
Aug 29, 2023
Member
andreslucena
left a comment
There was a problem hiding this comment.
👍🏽 I can't find references to this hook, neither. I also think that I found another one (I'll open a PR with that one).
I'll also change the title of the PR to reference this particular hook.
:upcoming_meeting_for_card
Member
|
@alecslupu as we mentioned in the related issue, we still have pending a bug related to this view hook that's on v0.26 / v0.27. We should make the fix against Meanwhile, I'll merge this one as it's great for v0.28.dev |
entantoencuanto
added a commit
that referenced
this pull request
Aug 30, 2023
* develop: Add recognition to BrowserStack in the README (#11546) Remove unused view hook for `:upcoming_meeting_for_card` (#11543) Remove unused dependency: `wicked` (#11150) Clean-up initiatives signature URLs and methods (#11545) Refactor initiative signing wizard (#10731) Fix Permissions screen on budgets throw errors (#11532) Redesign: read more literal (#11516) Fix 'download your data' when there are comments on budgets (#11531)
entantoencuanto
added a commit
that referenced
this pull request
Sep 8, 2023
…gn-staging * fix/activities-block-follow-button: (27 commits) Add tests to follow button in processes and assemblies landing page Add follow button to participatory spaces last activities content block Remove duplication from participatory spaces publications controllers (#11549) Fix the a11y tool icons with redesign (#11175) Remove duplication from amendments events specs (#11553) Remove duplication from elections' user roles forms (#11548) Update Node.js from v16.13.0 to v18.17.1 (#11564) Remove duplication from stats presenters (#11551) Fix Bootsnap configuration (#11483) Remove duplication for add questions specs examples (#11559) Remove duplication from invites queries (#11552) Fix typos and copy-paste errors from comments and examples (#11536) Fix conference venues meetings visibility (#11542) Add recognition to BrowserStack in the README (#11546) Remove unused view hook for `:upcoming_meeting_for_card` (#11543) Remove unused dependency: `wicked` (#11150) Clean-up initiatives signature URLs and methods (#11545) Refactor initiative signing wizard (#10731) Fix Permissions screen on budgets throw errors (#11532) Redesign: read more literal (#11516) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While researching a fix for #11541, i could not find any usages of the
upcoming_meeting_for_cardhook. Therefore this needs to go away.Investigating 0.26 branch, i could see that this hook is being used by:
📌 Related Issues
Link your PR to an issue
Testing
Make sure the pipeline is green