Skip to content

Redesign: participatory process steps#11226

Merged
alecslupu merged 11 commits intodevelopfrom
feature/redesign-participatory-process-steps
Jul 28, 2023
Merged

Redesign: participatory process steps#11226
alecslupu merged 11 commits intodevelopfrom
feature/redesign-participatory-process-steps

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Jul 18, 2023 •
edited
Loading

🎩 What? Why?

This PR:

  • Removes the views, related path and controller of the participatory processes steps index which is deprecated in favor of a modal displaying all the steps.
  • Extracts the steps modal from the Phase & duration content block to a cell to be available in the processes show even when the content block is disables.
  • Fixes some accessibility issues of the phases modal (some styles are pending to review).
  • Allows to call the phases modal cell with a parameter to open it automatically and uses this feature to change the link in the process breadcrumb dropdown to redirect to the landing page with the modal open.
  • Unskips and adapts tests related with steps to the changes.
  • Hides the active step link in the process breadcrumb dropdown if no steps are present.
  • Replaces a hard coded text with correct translation inside steps modal.

📌 Related Issues

Link your PR to an issue

Testing

Describe the best way to test or validate your PR.

📷 Screenshots

Please add screenshots of the changes you are proposing
Description

♥️ Thank you!

@entantoencuanto entantoencuanto force-pushed the feature/redesign-participatory-process-steps branch from b4912fb to e5faf1c Compare July 18, 2023 17:09
@alecslupu alecslupu added the project: redesign Barcelona City Council contract label Jul 19, 2023
@entantoencuanto entantoencuanto added project: redesign Barcelona City Council contract and removed project: redesign Barcelona City Council contract labels Jul 19, 2023
@entantoencuanto entantoencuanto marked this pull request as ready for review July 19, 2023 15:15
@entantoencuanto entantoencuanto requested a review from ferblape July 19, 2023 15:15
@furilo
Copy link
Copy Markdown
Contributor

furilo commented Jul 19, 2023

@decidim/product you can check this in:

https://decidim-redesign.populate.tools/processes/Decidim4Dummies

image

ferblape
ferblape previously approved these changes Jul 20, 2023
View reviewed changes
@ferblape ferblape requested a review from a team July 20, 2023 04:19
@carolromero carolromero mentioned this pull request Jul 21, 2023
Closed
carolromero
carolromero previously approved these changes Jul 21, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@carolromero carolromero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @entantoencuanto!

@alecslupu
Copy link
Copy Markdown
Contributor

alecslupu commented Jul 25, 2023

@entantoencuanto can you fix the conflict from here, so I can pick it up ?

@ferblape ferblape requested a review from a team July 26, 2023 08:09
@ferblape ferblape dismissed stale reviews from carolromero and themself via 2d59884 July 26, 2023 10:08
@ferblape
Copy link
Copy Markdown
Contributor

ferblape commented Jul 27, 2023

@alecslupu done!

@alecslupu alecslupu merged commit 976431d into develop Jul 28, 2023
@alecslupu alecslupu deleted the feature/redesign-participatory-process-steps branch July 28, 2023 06:33
entantoencuanto added a commit that referenced this pull request Jul 28, 2023
@entantoencuanto
Merge branch 'develop' into feature/redesign-staging
85e414a 
* develop:
  Reorder and renumber the RELEASES_NOTES (#11379)
  Add videos services to CSP (youtube-nocookie.com, meet.jit.si, etc) (#11155)
  Alert from frontend errors in critical paths (#10937)
  Redesign: comments issues (#11363)
  Redesign: participatory process steps (#11226)
  Redesign: meetings map (#11383)
  Redesign: rename layouts (#11126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@carolromero carolromero carolromero left review comments

+2 more reviewers

@alecslupu alecslupu alecslupu approved these changes

@ferblape ferblape ferblape left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

project: redesign Barcelona City Council contract

Projects

No open projects
PX Redesign
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Redesign / Steps link in Space dropdown

7 participants

@entantoencuanto @furilo @alecslupu @ferblape @carolromero @andreslucena @Crashillo