Conversation
furilo
previously approved these changes
Jul 26, 2023
ferblape
previously approved these changes
Jul 26, 2023
Contributor
|
@Crashillo still draft? |
alecslupu
suggested changes
Jul 26, 2023
Contributor
There was a problem hiding this comment.
Almost there! The space required for map is also present in meetings component homepage and directory listing.
We have 2 options:
- Edit decidim-meetings/app/views/decidim/meetings/shared/_index.html.erb and add the same
Decidim::Map.available?(:geocoding, :dynamic)condition in continuation ofdisplay_map - Patch all the templates where this information is filled in and add same
Decidim::Map.available?(:geocoding, :dynamic).
Also the same behavior is present on the proposals component when geocoding is enabled.
Contributor
|
@Crashillo, could we add in this PR the same fix for the proposals index page? |
entantoencuanto
added a commit
that referenced
this pull request
Jul 28, 2023
* develop: Reorder and renumber the RELEASES_NOTES (#11379) Add videos services to CSP (youtube-nocookie.com, meet.jit.si, etc) (#11155) Alert from frontend errors in critical paths (#10937) Redesign: comments issues (#11363) Redesign: participatory process steps (#11226) Redesign: meetings map (#11383) Redesign: rename layouts (#11126)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Hide the map spacing when is not configured, for the meetings content_block
📌 Related Issues
📷 Screenshots