Skip to content

Worker dashboard fixes#2747

Merged
mrocklin merged 5 commits intodask:masterfrom
mrocklin:worker-dashboard-fixes
Jun 5, 2019
Merged

Worker dashboard fixes#2747
mrocklin merged 5 commits intodask:masterfrom
mrocklin:worker-dashboard-fixes

Conversation

@mrocklin
Copy link
Copy Markdown
Member

@mrocklin mrocklin commented Jun 4, 2019

Related to #2738

This fixes a few small issues with the worker dashboards

mrocklin added 4 commits June 3, 2019 20:01
To do this we ...

1.  Remove the baked in "info" link in the base template
2.  Add that to the scheduler's list of links
3.  Add a redirect from "info" to the actual page
4.  Create a generic redirect route
5.  Move that and the RequestHandler to utils to avoid code duplication
    between scheduler and worker

Fixes dask#2722
@jakirkham
Copy link
Copy Markdown
Member

@birdsarah, would you be willing to try this out?

@birdsarah
Copy link
Copy Markdown
Contributor

As always, if I have the time. Feel free to ping me on things that I might be interested in. But my willingness and my ability to help are not correlated.

@mrocklin mrocklin self-assigned this Jun 4, 2019
@jakirkham
Copy link
Copy Markdown
Member

Sure, am mainly asking as it pertains to the issue you raised. If you don't have time, no worries.

@mrocklin mrocklin merged commit 2a1e089 into dask:master Jun 5, 2019
@mrocklin mrocklin deleted the worker-dashboard-fixes branch June 5, 2019 17:09
muammar added a commit to muammar/distributed that referenced this pull request Jun 12, 2019
* upstream/master: (58 commits)
  Add unknown pytest markers (dask#2764)
  Delay lookup of allowed failures. (dask#2761)
  Change address -> worker in ColumnDataSource for nbytes plot (dask#2755)
  Remove module state in Prometheus Handlers (dask#2760)
  Add stress test for UCX (dask#2759)
  Add nanny logs (dask#2744)
  Move some of the adaptive logic into the scheduler (dask#2735)
  Add SpecCluster.new_worker_spec method (dask#2751)
  Worker dashboard fixes (dask#2747)
  Add async context managers to scheduler/worker classes (dask#2745)
  Fix the resource key representation before sending graphs (dask#2716) (dask#2733)
  Allow user to configure whether workers are daemon. (dask#2739)
  Pin pytest >=4 with pip in appveyor and python 3.5 (dask#2737)
  Add Experimental UCX Comm (dask#2591)
  Close nannies gracefully (dask#2731)
  add kwargs to progressbars (dask#2638)
  Add back LocalCluster.__repr__. (dask#2732)
  Move bokeh module to dashboard (dask#2724)
  Close clusters at exit (dask#2730)
  Add SchedulerPlugin TaskState example (dask#2622)
  ...
muammar added a commit to muammar/distributed that referenced this pull request Jul 18, 2019
* upstream/master: (43 commits)
  Add unknown pytest markers (dask#2764)
  Delay lookup of allowed failures. (dask#2761)
  Change address -> worker in ColumnDataSource for nbytes plot (dask#2755)
  Remove module state in Prometheus Handlers (dask#2760)
  Add stress test for UCX (dask#2759)
  Add nanny logs (dask#2744)
  Move some of the adaptive logic into the scheduler (dask#2735)
  Add SpecCluster.new_worker_spec method (dask#2751)
  Worker dashboard fixes (dask#2747)
  Add async context managers to scheduler/worker classes (dask#2745)
  Fix the resource key representation before sending graphs (dask#2716) (dask#2733)
  Allow user to configure whether workers are daemon. (dask#2739)
  Pin pytest >=4 with pip in appveyor and python 3.5 (dask#2737)
  Add Experimental UCX Comm (dask#2591)
  Close nannies gracefully (dask#2731)
  add kwargs to progressbars (dask#2638)
  Add back LocalCluster.__repr__. (dask#2732)
  Move bokeh module to dashboard (dask#2724)
  Close clusters at exit (dask#2730)
  Add SchedulerPlugin TaskState example (dask#2622)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants