@manugarri thanks for the PR. It looks like interval is already a valid argument for TextProgressBars

Are there other kwargs you wish to pass ? If so, perhaps add a test to https://github.com/dask/distributed/blob/master/distributed/diagnostics/tests/test_progressbar.py ?

@quasiben I know, and this PR basically allows you to pass the argument interval to the general function progress. This way you can add the interval when you are running a cli script.

If not the only alternative to reduce the interval (which produces a long log file on Yarn EMR) is to do something like this (which works, but its not as concise).

from distributed.diagnostics.progressbar import TextProgressBar
from distributed.client import futures_of
output =output.persist()
TextProgressBar(futures_of(output), interval="10s")
output.compute()

Regarding the tests, I can add them but i am not sure it makes sense (since Im not altering the ProgressBar class at all, only allowing it to process kwargs).

Ah, apologies. I misunderstood.

I think if you want to use progress with arbitrary kwargs you will need to change the assertion in the function definition.

@mrocklin do you recall why this assertion is made ?

@mrocklin do you recall why this assertion is made ?

Unfortunately not

@quasiben yup that makes sense, it is easy to assign the remaining bar specific args to a variable and pop them off the kwargs so the assertion wont fail (even though it would be good to know why that assert is there)

Checking in, what's the status here?

@manugarri are you planning on removing the assertion and adding a test ?

@quasiben I am, my son was just born 2 days ago and we just left the hospital. Will do a PR as soon as I can :D

@manugarri congratulations!!! be with family -- this can wait

@quasiben I removed the assertion, let me know if its ok :)

@manugarri apologies for dropping this. There are still some linting issues -- if you run black distributed this should correct everything for you. Also, I would recommend adding the following test to test_progressbar.py

def test_progress_function_w_kwargs(client, capsys):
    f = client.submit(lambda: 1)
    g = client.submit(lambda: 2)

    progress(f, interval="20ms")
    check_bar_completed(capsys)

Merging this in. Thanks @manugarri !

Also, I notice that this is your first code contribution to this repository. Welcome!

Yes, thank you @manugarri !

Thanks for merging @mrocklin

thanks guys!, i apologize for not adding the test, im a bit behind these days :)

It seems we forgot to merge. Sorry about that. Have gone ahead and merged. Thanks all! 😄